HID: intel-ish-hid: fix wrong error handling in ishtp_cl_alloc_tx_ring()

lixuzha · Jiri Kosina · commit 16ff7bf6dbcc · 2019-10-16T08:26:55.000+02:00
When allocating tx ring buffers failed, should free tx buffers, not rx buffers.

Signed-off-by: Zhang Lixu &lt;lixu.zhang@intel.com&gt;
Acked-by: Srinivas Pandruvada &lt;srinivas.pandruvada@linux.intel.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
diff --git a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
@@ -84,7 +84,7 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)
 	return	0;
 out:
 	dev_err(&cl->device->dev, "error in allocating Tx pool\n");
-	ishtp_cl_free_rx_ring(cl);
+	ishtp_cl_free_tx_ring(cl);
 	return	-ENOMEM;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)`
`84`	`84`	`return 0;`
`85`	`85`	`out:`
`86`	`86`	`dev_err(&cl->device->dev, "error in allocating Tx pool\n");`
`87`		`- ishtp_cl_free_rx_ring(cl);`
	`87`	`+ ishtp_cl_free_tx_ring(cl);`
`88`	`88`	`return -ENOMEM;`
`89`	`89`	`}`
`90`	`90`