Skip to content

Commit 1717cc5

Browse files
superm1alexdeucher
authored andcommitted
drm/amd: Fix initialization mistake for NBIO 7.3.0
The same strapping initialization issue that happened on NBIO 7.5.1 appears to be happening on NBIO 7.3.0. Apply the same fix to 7.3.0 as well. Note: This workaround relies upon the integrated GPU being enabled in BIOS. If the integrated GPU is disabled in BIOS a different workaround will be required. Reported-by: Thomas Glanzmann <[email protected]> Cc: Basavaraj Natikar <[email protected]> Link: https://lore.kernel.org/linux-usb/Y%[email protected]/T/#u Signed-off-by: Mario Limonciello <[email protected]> Reviewed-by: Alex Deucher <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 93bb18d commit 1717cc5

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

drivers/gpu/drm/amd/amdgpu/nbio_v7_2.c

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -382,11 +382,6 @@ static void nbio_v7_2_init_registers(struct amdgpu_device *adev)
382382
if (def != data)
383383
WREG32_PCIE_PORT(SOC15_REG_OFFSET(NBIO, 0, regBIF1_PCIE_MST_CTRL_3), data);
384384
break;
385-
case IP_VERSION(7, 5, 1):
386-
data = RREG32_SOC15(NBIO, 0, regRCC_DEV2_EPF0_STRAP2);
387-
data &= ~RCC_DEV2_EPF0_STRAP2__STRAP_NO_SOFT_RESET_DEV2_F0_MASK;
388-
WREG32_SOC15(NBIO, 0, regRCC_DEV2_EPF0_STRAP2, data);
389-
fallthrough;
390385
default:
391386
def = data = RREG32_PCIE_PORT(SOC15_REG_OFFSET(NBIO, 0, regPCIE_CONFIG_CNTL));
392387
data = REG_SET_FIELD(data, PCIE_CONFIG_CNTL,
@@ -399,6 +394,15 @@ static void nbio_v7_2_init_registers(struct amdgpu_device *adev)
399394
break;
400395
}
401396

397+
switch (adev->ip_versions[NBIO_HWIP][0]) {
398+
case IP_VERSION(7, 3, 0):
399+
case IP_VERSION(7, 5, 1):
400+
data = RREG32_SOC15(NBIO, 0, regRCC_DEV2_EPF0_STRAP2);
401+
data &= ~RCC_DEV2_EPF0_STRAP2__STRAP_NO_SOFT_RESET_DEV2_F0_MASK;
402+
WREG32_SOC15(NBIO, 0, regRCC_DEV2_EPF0_STRAP2, data);
403+
break;
404+
}
405+
402406
if (amdgpu_sriov_vf(adev))
403407
adev->rmmio_remap.reg_offset = SOC15_REG_OFFSET(NBIO, 0,
404408
regBIF_BX_PF0_HDP_MEM_COHERENCY_FLUSH_CNTL) << 2;

0 commit comments

Comments
 (0)