Skip to content

Commit 171cfa0

Browse files
committed
torture: Place --bootargs parameters at end of -append list
Currently, the kernel boot parameters specified by the kvm.sh --bootargs parameter are placed near the beginning of the -append list that is passed to qemu. This means that in the not-uncommon case of a kernel boot parameter where the last argument wins, the --bootargs list overrides neither the list in the .boot file nor the additional parameters supplied by the rcutorture scripting. This commit therefore places the kernel boot parameters specified by the kvm.sh --bootargs parameter at the end of qemu's -append list. Signed-off-by: Paul E. McKenney <[email protected]>
1 parent 2f25542 commit 171cfa0

File tree

7 files changed

+17
-12
lines changed

7 files changed

+17
-12
lines changed

tools/testing/selftests/rcutorture/bin/functions.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ checkarg () {
4545
configfrag_boot_params () {
4646
if test -r "$2.boot"
4747
then
48-
echo $1 `grep -v '^#' "$2.boot" | tr '\012' ' '`
48+
echo `grep -v '^#' "$2.boot" | tr '\012' ' '` $1
4949
else
5050
echo $1
5151
fi

tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ boot_args="`configfrag_boot_params "$boot_args_in" "$config_template"`"
162162
boot_args="`per_version_boot_params "$boot_args" $resdir/.config $seconds`"
163163
if test -n "$TORTURE_BOOT_GDB_ARG"
164164
then
165-
boot_args="$boot_args $TORTURE_BOOT_GDB_ARG"
165+
boot_args="$TORTURE_BOOT_GDB_ARG $boot_args"
166166
fi
167167

168168
# Give bare-metal advice

tools/testing/selftests/rcutorture/configs/lock/ver_functions.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@ locktorture_param_onoff () {
2222
#
2323
# Adds per-version torture-module parameters to kernels supporting them.
2424
per_version_boot_params () {
25-
echo $1 `locktorture_param_onoff "$1" "$2"` \
25+
echo `locktorture_param_onoff "$1" "$2"` \
2626
locktorture.stat_interval=15 \
2727
locktorture.shutdown_secs=$3 \
28-
locktorture.verbose=1
28+
locktorture.verbose=1 \
29+
$1
2930
}

tools/testing/selftests/rcutorture/configs/rcu/ver_functions.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,11 @@ rcutorture_param_stat_interval () {
4646
#
4747
# Adds per-version torture-module parameters to kernels supporting them.
4848
per_version_boot_params () {
49-
echo $1 `rcutorture_param_onoff "$1" "$2"` \
49+
echo `rcutorture_param_onoff "$1" "$2"` \
5050
`rcutorture_param_n_barrier_cbs "$1"` \
5151
`rcutorture_param_stat_interval "$1"` \
5252
rcutorture.shutdown_secs=$3 \
5353
rcutorture.test_no_idle_hz=1 \
54-
rcutorture.verbose=1
54+
rcutorture.verbose=1 \
55+
$1
5556
}

tools/testing/selftests/rcutorture/configs/rcuscale/ver_functions.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#
1212
# Adds per-version torture-module parameters to kernels supporting them.
1313
per_version_boot_params () {
14-
echo $1 rcuscale.shutdown=1 \
15-
rcuscale.verbose=0
14+
echo rcuscale.shutdown=1 \
15+
rcuscale.verbose=0 \
16+
$1
1617
}

tools/testing/selftests/rcutorture/configs/refscale/ver_functions.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#
1212
# Adds per-version torture-module parameters to kernels supporting them.
1313
per_version_boot_params () {
14-
echo $1 refscale.shutdown=1 \
15-
refscale.verbose=0
14+
echo refscale.shutdown=1 \
15+
refscale.verbose=0 \
16+
$1
1617
}

tools/testing/selftests/rcutorture/configs/scf/ver_functions.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@ scftorture_param_onoff () {
2222
#
2323
# Adds per-version torture-module parameters to kernels supporting them.
2424
per_version_boot_params () {
25-
echo $1 `scftorture_param_onoff "$1" "$2"` \
25+
echo `scftorture_param_onoff "$1" "$2"` \
2626
scftorture.stat_interval=15 \
2727
scftorture.shutdown_secs=$3 \
28-
scftorture.verbose=1
28+
scftorture.verbose=1 \
29+
$1
2930
}

0 commit comments

Comments
 (0)