Skip to content

Commit 172b14b

Browse files
JasonYanHwfelipebalbi
authored andcommitted
usb: cdns3: gadget: make a bunch of functions static
Fix the following sparse warning: drivers/usb/cdns3/gadget.c:85:6: warning: symbol 'cdns3_clear_register_bit' was not declared. Should it be static? drivers/usb/cdns3/gadget.c:140:26: warning: symbol 'cdns3_next_align_buf' was not declared. Should it be static? drivers/usb/cdns3/gadget.c:151:22: warning: symbol 'cdns3_next_priv_request' was not declared. Should it be static? drivers/usb/cdns3/gadget.c:193:5: warning: symbol 'cdns3_ring_size' was not declared. Should it be static? drivers/usb/cdns3/gadget.c:348:6: warning: symbol 'cdns3_move_deq_to_next_trb' was not declared. Should it be static? drivers/usb/cdns3/gadget.c:514:20: warning: symbol 'cdns3_wa2_gadget_giveback' was not declared. Should it be static? drivers/usb/cdns3/gadget.c:554:5: warning: symbol 'cdns3_wa2_gadget_ep_queue' was not declared. Should it be static? drivers/usb/cdns3/gadget.c:839:6: warning: symbol 'cdns3_wa1_restore_cycle_bit' was not declared. Should it be static? drivers/usb/cdns3/gadget.c:1907:6: warning: symbol 'cdns3_stream_ep_reconfig' was not declared. Should it be static? drivers/usb/cdns3/gadget.c:1928:6: warning: symbol 'cdns3_configure_dmult' was not declared. Should it be static? Reported-by: Hulk Robot <[email protected]> Reviewed-by: Peter Chen <[email protected]> Signed-off-by: Jason Yan <[email protected]> Signed-off-by: Felipe Balbi <[email protected]>
1 parent 6045dd7 commit 172b14b

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

drivers/usb/cdns3/gadget.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ static int cdns3_ep_run_stream_transfer(struct cdns3_endpoint *priv_ep,
8282
* @ptr: address of device controller register to be read and changed
8383
* @mask: bits requested to clar
8484
*/
85-
void cdns3_clear_register_bit(void __iomem *ptr, u32 mask)
85+
static void cdns3_clear_register_bit(void __iomem *ptr, u32 mask)
8686
{
8787
mask = readl(ptr) & ~mask;
8888
writel(mask, ptr);
@@ -137,7 +137,7 @@ struct usb_request *cdns3_next_request(struct list_head *list)
137137
*
138138
* Returns buffer or NULL if no buffers in list
139139
*/
140-
struct cdns3_aligned_buf *cdns3_next_align_buf(struct list_head *list)
140+
static struct cdns3_aligned_buf *cdns3_next_align_buf(struct list_head *list)
141141
{
142142
return list_first_entry_or_null(list, struct cdns3_aligned_buf, list);
143143
}
@@ -148,7 +148,7 @@ struct cdns3_aligned_buf *cdns3_next_align_buf(struct list_head *list)
148148
*
149149
* Returns request or NULL if no requests in list
150150
*/
151-
struct cdns3_request *cdns3_next_priv_request(struct list_head *list)
151+
static struct cdns3_request *cdns3_next_priv_request(struct list_head *list)
152152
{
153153
return list_first_entry_or_null(list, struct cdns3_request, list);
154154
}
@@ -190,7 +190,7 @@ dma_addr_t cdns3_trb_virt_to_dma(struct cdns3_endpoint *priv_ep,
190190
return priv_ep->trb_pool_dma + offset;
191191
}
192192

193-
int cdns3_ring_size(struct cdns3_endpoint *priv_ep)
193+
static int cdns3_ring_size(struct cdns3_endpoint *priv_ep)
194194
{
195195
switch (priv_ep->type) {
196196
case USB_ENDPOINT_XFER_ISOC:
@@ -345,7 +345,7 @@ static void cdns3_ep_inc_deq(struct cdns3_endpoint *priv_ep)
345345
cdns3_ep_inc_trb(&priv_ep->dequeue, &priv_ep->ccs, priv_ep->num_trbs);
346346
}
347347

348-
void cdns3_move_deq_to_next_trb(struct cdns3_request *priv_req)
348+
static void cdns3_move_deq_to_next_trb(struct cdns3_request *priv_req)
349349
{
350350
struct cdns3_endpoint *priv_ep = priv_req->priv_ep;
351351
int current_trb = priv_req->start_trb;
@@ -511,7 +511,7 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
511511
}
512512
}
513513

514-
struct usb_request *cdns3_wa2_gadget_giveback(struct cdns3_device *priv_dev,
514+
static struct usb_request *cdns3_wa2_gadget_giveback(struct cdns3_device *priv_dev,
515515
struct cdns3_endpoint *priv_ep,
516516
struct cdns3_request *priv_req)
517517
{
@@ -551,7 +551,7 @@ struct usb_request *cdns3_wa2_gadget_giveback(struct cdns3_device *priv_dev,
551551
return &priv_req->request;
552552
}
553553

554-
int cdns3_wa2_gadget_ep_queue(struct cdns3_device *priv_dev,
554+
static int cdns3_wa2_gadget_ep_queue(struct cdns3_device *priv_dev,
555555
struct cdns3_endpoint *priv_ep,
556556
struct cdns3_request *priv_req)
557557
{
@@ -836,7 +836,7 @@ void cdns3_gadget_giveback(struct cdns3_endpoint *priv_ep,
836836
cdns3_gadget_ep_free_request(&priv_ep->endpoint, request);
837837
}
838838

839-
void cdns3_wa1_restore_cycle_bit(struct cdns3_endpoint *priv_ep)
839+
static void cdns3_wa1_restore_cycle_bit(struct cdns3_endpoint *priv_ep)
840840
{
841841
/* Work around for stale data address in TRB*/
842842
if (priv_ep->wa1_set) {
@@ -1904,7 +1904,7 @@ static int cdns3_ep_onchip_buffer_reserve(struct cdns3_device *priv_dev,
19041904
return 0;
19051905
}
19061906

1907-
void cdns3_stream_ep_reconfig(struct cdns3_device *priv_dev,
1907+
static void cdns3_stream_ep_reconfig(struct cdns3_device *priv_dev,
19081908
struct cdns3_endpoint *priv_ep)
19091909
{
19101910
if (!priv_ep->use_streams || priv_dev->gadget.speed < USB_SPEED_SUPER)
@@ -1925,7 +1925,7 @@ void cdns3_stream_ep_reconfig(struct cdns3_device *priv_dev,
19251925
EP_CFG_TDL_CHK | EP_CFG_SID_CHK);
19261926
}
19271927

1928-
void cdns3_configure_dmult(struct cdns3_device *priv_dev,
1928+
static void cdns3_configure_dmult(struct cdns3_device *priv_dev,
19291929
struct cdns3_endpoint *priv_ep)
19301930
{
19311931
struct cdns3_usb_regs __iomem *regs = priv_dev->regs;

0 commit comments

Comments
 (0)