Skip to content

Commit 173876a

Browse files
committed
drm/i915/ddi: Optimize mtl_port_buf_ctl_program
A small optimization and cleanup for mtl_port_buf_ctl_program function which lets use intel_de_rmw instead of a intel_de_read and intel_de_write. Signed-off-by: Suraj Kandpal <[email protected]> Reviewed-by: Jani Nikula <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 2fcde2f commit 173876a

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

drivers/gpu/drm/i915/display/intel_ddi.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2537,13 +2537,10 @@ static void mtl_port_buf_ctl_program(struct intel_encoder *encoder,
25372537
struct intel_display *display = to_intel_display(encoder);
25382538
struct intel_digital_port *dig_port = enc_to_dig_port(encoder);
25392539
enum port port = encoder->port;
2540-
u32 val;
2540+
u32 val = 0;
25412541

2542-
val = intel_de_read(display, XELPDP_PORT_BUF_CTL1(i915, port));
2543-
val &= ~XELPDP_PORT_WIDTH_MASK;
25442542
val |= XELPDP_PORT_WIDTH(mtl_get_port_width(crtc_state->lane_count));
25452543

2546-
val &= ~XELPDP_PORT_BUF_PORT_DATA_WIDTH_MASK;
25472544
if (intel_dp_is_uhbr(crtc_state))
25482545
val |= XELPDP_PORT_BUF_PORT_DATA_40BIT;
25492546
else
@@ -2552,7 +2549,9 @@ static void mtl_port_buf_ctl_program(struct intel_encoder *encoder,
25522549
if (dig_port->lane_reversal)
25532550
val |= XELPDP_PORT_REVERSAL;
25542551

2555-
intel_de_write(display, XELPDP_PORT_BUF_CTL1(display, port), val);
2552+
intel_de_rmw(display, XELPDP_PORT_BUF_CTL1(display, port),
2553+
XELPDP_PORT_WIDTH_MASK | XELPDP_PORT_BUF_PORT_DATA_WIDTH_MASK,
2554+
val);
25562555
}
25572556

25582557
static void mtl_port_buf_ctl_io_selection(struct intel_encoder *encoder)

0 commit comments

Comments
 (0)