Skip to content

Commit 1776921

Browse files
Thippeswamy Havaligekwilczynski
authored andcommitted
PCI: xilinx-nwl: Rename the NWL_ECAM_VALUE_DEFAULT macro
Rename the NWL_ECAM_VALUE_DEFAULT macro to NWL_ECAM_MAX_SIZE and drop the no longer needed ecam_value variable from struct nwl_pcie. [kwilczynski: commit log] Link: https://lore.kernel.org/linux-pci/[email protected] Signed-off-by: Thippeswamy Havalige <[email protected]> Signed-off-by: Krzysztof Wilczyński <[email protected]>
1 parent 22f38a2 commit 1776921

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/pci/controller/pcie-xilinx-nwl.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
#define E_ECAM_CR_ENABLE BIT(0)
127127
#define E_ECAM_SIZE_LOC GENMASK(20, 16)
128128
#define E_ECAM_SIZE_SHIFT 16
129-
#define NWL_ECAM_VALUE_DEFAULT 12
129+
#define NWL_ECAM_MAX_SIZE 12
130130

131131
#define CFG_DMA_REG_BAR GENMASK(2, 0)
132132
#define CFG_PCIE_CACHE GENMASK(7, 0)
@@ -165,7 +165,6 @@ struct nwl_pcie {
165165
u32 ecam_size;
166166
int irq_intx;
167167
int irq_misc;
168-
u32 ecam_value;
169168
struct nwl_msi msi;
170169
struct irq_domain *legacy_irq_domain;
171170
struct clk *clk;
@@ -674,7 +673,7 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie)
674673
E_ECAM_CR_ENABLE, E_ECAM_CONTROL);
675674

676675
nwl_bridge_writel(pcie, nwl_bridge_readl(pcie, E_ECAM_CONTROL) |
677-
(pcie->ecam_value << E_ECAM_SIZE_SHIFT),
676+
(NWL_ECAM_MAX_SIZE << E_ECAM_SIZE_SHIFT),
678677
E_ECAM_CONTROL);
679678

680679
nwl_bridge_writel(pcie, lower_32_bits(pcie->phys_ecam_base),
@@ -782,7 +781,6 @@ static int nwl_pcie_probe(struct platform_device *pdev)
782781
pcie = pci_host_bridge_priv(bridge);
783782

784783
pcie->dev = dev;
785-
pcie->ecam_value = NWL_ECAM_VALUE_DEFAULT;
786784

787785
err = nwl_pcie_parse_dt(pcie, pdev);
788786
if (err) {

0 commit comments

Comments
 (0)