Skip to content

Commit 177b76a

Browse files
ChristianKoenigAMDalexdeucher
authored andcommitted
drm/amdgpu: mark a bunch of module parameters unsafe
We sometimes have people trying to use debugging options in production environments. Mark options only meant to be used for debugging as unsafe so that the kernel is tainted when they are used. Signed-off-by: Christian König <[email protected]> Acked-by: Felix Kuehling <[email protected]> Acked-by: Simona Vetter <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent e996127 commit 177b76a

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ module_param_named(runpm, amdgpu_runtime_pm, int, 0444);
399399
* the kernel log for the list of IPs on the asic. The default is 0xffffffff (enable all blocks on a device).
400400
*/
401401
MODULE_PARM_DESC(ip_block_mask, "IP Block Mask (all blocks enabled (default))");
402-
module_param_named(ip_block_mask, amdgpu_ip_block_mask, uint, 0444);
402+
module_param_named_unsafe(ip_block_mask, amdgpu_ip_block_mask, uint, 0444);
403403

404404
/**
405405
* DOC: bapm (int)
@@ -457,7 +457,7 @@ module_param_named(vm_update_mode, amdgpu_vm_update_mode, int, 0444);
457457
* Enable experimental hw support (1 = enable). The default is 0 (disabled).
458458
*/
459459
MODULE_PARM_DESC(exp_hw_support, "experimental hw support (1 = enable, 0 = disable (default))");
460-
module_param_named(exp_hw_support, amdgpu_exp_hw_support, int, 0444);
460+
module_param_named_unsafe(exp_hw_support, amdgpu_exp_hw_support, int, 0444);
461461

462462
/**
463463
* DOC: dc (int)
@@ -568,14 +568,14 @@ module_param_named(compute_multipipe, amdgpu_compute_multipipe, int, 0444);
568568
* Set to enable GPU recovery mechanism (1 = enable, 0 = disable). The default is -1 (auto, disabled except SRIOV).
569569
*/
570570
MODULE_PARM_DESC(gpu_recovery, "Enable GPU recovery mechanism, (1 = enable, 0 = disable, -1 = auto)");
571-
module_param_named(gpu_recovery, amdgpu_gpu_recovery, int, 0444);
571+
module_param_named_unsafe(gpu_recovery, amdgpu_gpu_recovery, int, 0444);
572572

573573
/**
574574
* DOC: emu_mode (int)
575575
* Set value 1 to enable emulation mode. This is only needed when running on an emulator. The default is 0 (disabled).
576576
*/
577577
MODULE_PARM_DESC(emu_mode, "Emulation mode, (1 = enable, 0 = disable)");
578-
module_param_named(emu_mode, amdgpu_emu_mode, int, 0444);
578+
module_param_named_unsafe(emu_mode, amdgpu_emu_mode, int, 0444);
579579

580580
/**
581581
* DOC: ras_enable (int)
@@ -730,7 +730,7 @@ module_param_named(noretry, amdgpu_noretry, int, 0644);
730730
*/
731731
MODULE_PARM_DESC(force_asic_type,
732732
"A non negative value used to specify the asic type for all supported GPUs");
733-
module_param_named(force_asic_type, amdgpu_force_asic_type, int, 0444);
733+
module_param_named_unsafe(force_asic_type, amdgpu_force_asic_type, int, 0444);
734734

735735
/**
736736
* DOC: use_xgmi_p2p (int)
@@ -953,7 +953,7 @@ module_param_named(freesync_video, amdgpu_freesync_vid_mode, uint, 0444);
953953
* GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = baco)
954954
*/
955955
MODULE_PARM_DESC(reset_method, "GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = baco/bamaco)");
956-
module_param_named(reset_method, amdgpu_reset_method, int, 0644);
956+
module_param_named_unsafe(reset_method, amdgpu_reset_method, int, 0644);
957957

958958
/**
959959
* DOC: bad_page_threshold (int) Bad page threshold is specifies the
@@ -1049,7 +1049,7 @@ module_param_named(seamless, amdgpu_seamless, int, 0444);
10491049
* - 0x4: Disable GPU soft recovery, always do a full reset
10501050
*/
10511051
MODULE_PARM_DESC(debug_mask, "debug options for amdgpu, disabled by default");
1052-
module_param_named(debug_mask, amdgpu_debug_mask, uint, 0444);
1052+
module_param_named_unsafe(debug_mask, amdgpu_debug_mask, uint, 0444);
10531053

10541054
/**
10551055
* DOC: agp (int)

0 commit comments

Comments
 (0)