Skip to content

Commit 1994c31

Browse files
ddalessajgunthorpe
authored andcommitted
RDMA/hfi1: Consolidate software versions
There is no need to have separate user and kernel software versions. There is a single software that the kernel is compatible with. Also remove the notion of a "kernel type" that is long since deprecated. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dennis Dalessandro <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 676bffa commit 1994c31

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

drivers/infiniband/hw/hfi1/common.h

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,23 +137,6 @@
137137
#define HFI1_USER_SWVERSION ((HFI1_USER_SWMAJOR << HFI1_SWMAJOR_SHIFT) | \
138138
HFI1_USER_SWMINOR)
139139

140-
#ifndef HFI1_KERN_TYPE
141-
#define HFI1_KERN_TYPE 0
142-
#endif
143-
144-
/*
145-
* Similarly, this is the kernel version going back to the user. It's
146-
* slightly different, in that we want to tell if the driver was built as
147-
* part of a Intel release, or from the driver from openfabrics.org,
148-
* kernel.org, or a standard distribution, for support reasons.
149-
* The high bit is 0 for non-Intel and 1 for Intel-built/supplied.
150-
*
151-
* It's returned by the driver to the user code during initialization in the
152-
* spi_sw_version field of hfi1_base_info, so the user code can in turn
153-
* check for compatibility with the kernel.
154-
*/
155-
#define HFI1_KERN_SWVERSION ((HFI1_KERN_TYPE << 31) | HFI1_USER_SWVERSION)
156-
157140
/*
158141
* Diagnostics can send a packet by writing the following
159142
* struct to the diag packet special file.

drivers/infiniband/hw/hfi1/file_ops.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1222,7 +1222,7 @@ static int get_base_info(struct hfi1_filedata *fd, unsigned long arg, u32 len)
12221222

12231223
memset(&binfo, 0, sizeof(binfo));
12241224
binfo.hw_version = dd->revision;
1225-
binfo.sw_version = HFI1_KERN_SWVERSION;
1225+
binfo.sw_version = HFI1_USER_SWVERSION;
12261226
binfo.bthqp = RVT_KDETH_QP_PREFIX;
12271227
binfo.jkey = uctxt->jkey;
12281228
/*

0 commit comments

Comments
 (0)