Skip to content

Commit 19a4679

Browse files
committed
Merge branch 'mlxsw-fixes'
Ido Schimmel says: ==================== mlxsw: spectrum_flower: Do not stop at FLOW_ACTION_{VLAN_MANGLE, PRIORITY} Petr says: The handlers for FLOW_ACTION_VLAN_MANGLE and FLOW_ACTION_PRIORITY end by returning whatever the lower-level function that they call returns. If there are more actions lined up after one of these actions, those are never offloaded. Each of the two patches fixes one of those actions. v2: * Patch #1: Use valid SHA1 ID in Fixes line (Dave) ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 95099c5 + ccfc569 commit 19a4679

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -150,14 +150,20 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp,
150150
u8 prio = act->vlan.prio;
151151
u16 vid = act->vlan.vid;
152152

153-
return mlxsw_sp_acl_rulei_act_vlan(mlxsw_sp, rulei,
154-
act->id, vid,
155-
proto, prio, extack);
153+
err = mlxsw_sp_acl_rulei_act_vlan(mlxsw_sp, rulei,
154+
act->id, vid,
155+
proto, prio, extack);
156+
if (err)
157+
return err;
158+
break;
156159
}
157160
case FLOW_ACTION_PRIORITY:
158-
return mlxsw_sp_acl_rulei_act_priority(mlxsw_sp, rulei,
159-
act->priority,
160-
extack);
161+
err = mlxsw_sp_acl_rulei_act_priority(mlxsw_sp, rulei,
162+
act->priority,
163+
extack);
164+
if (err)
165+
return err;
166+
break;
161167
case FLOW_ACTION_MANGLE: {
162168
enum flow_action_mangle_base htype = act->mangle.htype;
163169
__be32 be_mask = (__force __be32) act->mangle.mask;

0 commit comments

Comments
 (0)