Skip to content

Commit 19adbe9

Browse files
hkallweittiwai
authored andcommitted
ALSA: hda: generic: Remove obsolete call to ledtrig_audio_get
Since 64f67b5 ("leds: trigger: audio: Add an activate callback to ensure the initial brightness is set") the audio triggers have an activate callback which sets the LED brightness as soon as the (default) trigger is bound to the LED device. So we can remove the call to ledtrig_audio_get. Positive side effect: We have no code dependency to ledtrig-audio any longer, therefore, if built as module, it's no longer loaded if not needed. Signed-off-by: Heiner Kallweit <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 3787ffd commit 19adbe9

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

sound/pci/hda/hda_generic.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3946,7 +3946,6 @@ static int create_mute_led_cdev(struct hda_codec *codec,
39463946
cdev->max_brightness = 1;
39473947
cdev->default_trigger = micmute ? "audio-micmute" : "audio-mute";
39483948
cdev->brightness_set_blocking = callback;
3949-
cdev->brightness = ledtrig_audio_get(idx);
39503949
cdev->flags = LED_CORE_SUSPENDRESUME;
39513950

39523951
err = led_classdev_register(&codec->core.dev, cdev);

0 commit comments

Comments
 (0)