Skip to content

Commit 19e0713

Browse files
seokw-Ryanakpm00
authored andcommitted
selftests/eventfd: correct test name and improve messages
- Rename test from eventfd_chek_flag_cloexec_and_nonblock to eventfd_check_flag_cloexec_and_nonblock. - Make the RDWR‐flag comment declarative: “The kernel automatically adds the O_RDWR flag.” - Update semaphore‐flag failure message to: “eventfd semaphore flag check failed: …” Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Ryan Chung <[email protected]> Reviewed-by: Wen Yang <[email protected]> Cc: Shuah Khan <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 780138b commit 19e0713

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

tools/testing/selftests/filesystems/eventfd/eventfd_test.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ TEST(eventfd_check_flag_rdwr)
5050
ASSERT_GE(fd, 0);
5151

5252
flags = fcntl(fd, F_GETFL);
53-
// since the kernel automatically added O_RDWR.
53+
// The kernel automatically adds the O_RDWR flag.
5454
EXPECT_EQ(flags, O_RDWR);
5555

5656
close(fd);
@@ -85,7 +85,7 @@ TEST(eventfd_check_flag_nonblock)
8585
close(fd);
8686
}
8787

88-
TEST(eventfd_chek_flag_cloexec_and_nonblock)
88+
TEST(eventfd_check_flag_cloexec_and_nonblock)
8989
{
9090
int fd, flags;
9191

@@ -178,8 +178,7 @@ TEST(eventfd_check_flag_semaphore)
178178
// The semaphore could only be obtained from fdinfo.
179179
ret = verify_fdinfo(fd, &err, "eventfd-semaphore: ", 19, "1\n");
180180
if (ret != 0)
181-
ksft_print_msg("eventfd-semaphore check failed, msg: %s\n",
182-
err.msg);
181+
ksft_print_msg("eventfd semaphore flag check failed: %s\n", err.msg);
183182
EXPECT_EQ(ret, 0);
184183

185184
close(fd);

0 commit comments

Comments
 (0)