Skip to content

Commit 1a23acc

Browse files
linuswarndb
authored andcommitted
ARM: ixp4xx: Consolidate Kconfig fixing issue
The IXP4xx Kconfig we ended up with for mach-ixp4xx creates as kismet warning: WARNING: unmet direct dependencies detected for GPIO_IXP4XX Depends on [n]: GPIOLIB [=y] && HAS_IOMEM [=y] && ARCH_IXP4XX [=y] && OF [=n] Selected by [y]: - ARCH_IXP4XX [=y] && <choice> This is because it is possible to select ARCH_IXP4XX witout OF while that selects the GPIO driver that now depends on OF. Fix this by creating a single ARCH_IXP4XX kconfig that selects USE_OF. Reported-by: kernel test robot <[email protected]> Signed-off-by: Linus Walleij <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: Imre Kaloz <[email protected]> Cc: Krzysztof Halasa <[email protected]> Link: https://lore.kernel.org/r/[email protected]' Signed-off-by: Arnd Bergmann <[email protected]>
1 parent 23b44f9 commit 1a23acc

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

arch/arm/mach-ixp4xx/Kconfig

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,17 @@ menuconfig ARCH_IXP4XX
33
bool "IXP4xx-based platforms"
44
depends on ARCH_MULTI_V5
55
depends on CPU_BIG_ENDIAN
6+
select ARM_APPENDED_DTB # Old Redboot bootloaders deployed
67
select CPU_XSCALE
78
select GPIO_IXP4XX
89
select GPIOLIB
910
select FORCE_PCI
11+
select I2C
12+
select I2C_IOP3XX
1013
select IXP4XX_IRQ
1114
select IXP4XX_TIMER
1215
select USB_EHCI_BIG_ENDIAN_DESC
1316
select USB_EHCI_BIG_ENDIAN_MMIO
14-
help
15-
Support for Intel's IXP4XX (XScale) family of processors.
16-
17-
if ARCH_IXP4XX
18-
19-
config MACH_IXP4XX_OF
20-
bool
21-
prompt "Device Tree IXP4xx boards"
22-
default y
23-
select ARM_APPENDED_DTB # Old Redboot bootloaders deployed
24-
select I2C
25-
select I2C_IOP3XX
2617
select USE_OF
2718
help
28-
Say 'Y' here to support Device Tree-based IXP4xx platforms.
29-
30-
endif
19+
Support for Intel's IXP4XX (XScale) family of processors.

0 commit comments

Comments
 (0)