Skip to content

Commit 1ad5dc3

Browse files
jhnikulawsakernel
authored andcommitted
i2c: i801: Fix incorrect and needless software PEC disabling
Commit a6b8bb6 ("i2c: i801: Fix handling SMBHSTCNT_PEC_EN") attempts to disable software PEC by clearing the SMBHSTCNT_PEC_EN (bit 7) in the SMBus Host Control register (I/O SMBHSTCNT) but incorrectly clears it in the PCI Host Configuration register (PCI SMBHSTCFG). This clearing is actually needless since after above commit the SMBHSTCNT_PEC_EN is never set and the register is initialized with known values. Signed-off-by: Jarkko Nikula <[email protected]> Acked-by: Heiner Kallweit <[email protected]> Reviewed-by: Jean Delvare <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent cc28e57 commit 1ad5dc3

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/i2c/busses/i2c-i801.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1657,7 +1657,6 @@ static void i801_setup_hstcfg(struct i801_priv *priv)
16571657
unsigned char hstcfg = priv->original_hstcfg;
16581658

16591659
hstcfg &= ~SMBHSTCFG_I2C_EN; /* SMBus timing */
1660-
hstcfg &= ~SMBHSTCNT_PEC_EN; /* Disable software PEC */
16611660
hstcfg |= SMBHSTCFG_HST_EN;
16621661
pci_write_config_byte(priv->pci_dev, SMBHSTCFG, hstcfg);
16631662
}

0 commit comments

Comments
 (0)