mailbox: imx: Fix return in imx_mu_scu_xlate()

Dan Carpenter · JassiBrar · commit 1b3a347b7d56 · 2020-05-30T16:07:51.000-05:00
This called from mbox_request_channel(). The caller is expecting error pointers and not NULL so this "return NULL;" will lead to an Oops. Fixes: 0a67003 ("mailbox: imx: add SCU MU support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
@@ -378,7 +378,7 @@ static struct mbox_chan *imx_mu_scu_xlate(struct mbox_controller *mbox,
 		break;
 	default:
 		dev_err(mbox->dev, "Invalid chan type: %d\n", type);
-		return NULL;
+		return ERR_PTR(-EINVAL);
 	}
 
 	if (chan >= mbox->num_chans) {

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,7 @@ static struct mbox_chan imx_mu_scu_xlate(struct mbox_controller mbox,`
`378`	`378`	`break;`
`379`	`379`	`default:`
`380`	`380`	`dev_err(mbox->dev, "Invalid chan type: %d\n", type);`
`381`		`- return NULL;`
	`381`	`+ return ERR_PTR(-EINVAL);`
`382`	`382`	`}`
`383`	`383`
`384`	`384`	`if (chan >= mbox->num_chans) {`