Skip to content

Commit 1b49cd7

Browse files
Yang Yingliangdavem330
authored andcommitted
devinet: fix memleak in inetdev_init()
When devinet_sysctl_register() failed, the memory allocated in neigh_parms_alloc() should be freed. Fixes: 20e61da ("ipv4: fail early when creating netdev named all or default") Signed-off-by: Yang Yingliang <[email protected]> Acked-by: Cong Wang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 8692cef commit 1b49cd7

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

net/ipv4/devinet.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ static struct in_device *inetdev_init(struct net_device *dev)
276276
err = devinet_sysctl_register(in_dev);
277277
if (err) {
278278
in_dev->dead = 1;
279+
neigh_parms_release(&arp_tbl, in_dev->arp_parms);
279280
in_dev_put(in_dev);
280281
in_dev = NULL;
281282
goto out;

0 commit comments

Comments
 (0)