Skip to content

Commit 1b56218

Browse files
Arseny Solokhagregkh
authored andcommitted
eeprom: make older eeprom drivers select NVMEM_SYSFS
misc/eeprom/{at24,at25,eeprom_93xx46} drivers all register their corresponding devices in the nvmem framework in compat mode which requires nvmem sysfs interface to be present. The latter, however, has been split out from nvmem under a separate Kconfig in commit ae0c2d7 ("nvmem: core: add NVMEM_SYSFS Kconfig"). As a result, probing certain I2C-attached EEPROMs now fails with at24: probe of 0-0050 failed with error -38 because of a stub implementation of nvmem_sysfs_setup_compat() in drivers/nvmem/nvmem.h. Update the nvmem dependency for these drivers so they could load again: at24 0-0050: 32768 byte 24c256 EEPROM, writable, 64 bytes/write Cc: Adrian Bunk <[email protected]> Cc: Bartosz Golaszewski <[email protected]> Cc: Srinivas Kandagatla <[email protected]> Cc: [email protected] # v5.2+ Signed-off-by: Arseny Solokha <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 10b0f1c commit 1b56218

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/misc/eeprom/Kconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ config EEPROM_AT24
55
tristate "I2C EEPROMs / RAMs / ROMs from most vendors"
66
depends on I2C && SYSFS
77
select NVMEM
8+
select NVMEM_SYSFS
89
select REGMAP_I2C
910
help
1011
Enable this driver to get read/write support to most I2C EEPROMs
@@ -34,6 +35,7 @@ config EEPROM_AT25
3435
tristate "SPI EEPROMs from most vendors"
3536
depends on SPI && SYSFS
3637
select NVMEM
38+
select NVMEM_SYSFS
3739
help
3840
Enable this driver to get read/write support to most SPI EEPROMs,
3941
after you configure the board init code to know about each eeprom
@@ -80,6 +82,7 @@ config EEPROM_93XX46
8082
depends on SPI && SYSFS
8183
select REGMAP
8284
select NVMEM
85+
select NVMEM_SYSFS
8386
help
8487
Driver for the microwire EEPROM chipsets 93xx46x. The driver
8588
supports both read and write commands and also the command to

0 commit comments

Comments
 (0)