Skip to content

Commit 1c22601

Browse files
mszyprowmripard
authored andcommitted
ARM: dts: sun8i: a83t: Correct USB3503 GPIOs polarity
Current USB3503 driver ignores GPIO polarity and always operates as if the GPIO lines were flagged as ACTIVE_HIGH. Fix the polarity for the existing USB3503 chip applications to match the chip specification and common convention for naming the pins. The only pin, which has to be ACTIVE_LOW is the reset pin. The remaining are ACTIVE_HIGH. This change allows later to fix the USB3503 driver to properly use generic GPIO bindings and read polarity from DT. Signed-off-by: Marek Szyprowski <[email protected]> Signed-off-by: Maxime Ripard <[email protected]>
1 parent 3d615c2 commit 1c22601

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@
101101
initial-mode = <1>; /* initialize in HUB mode */
102102
disabled-ports = <1>;
103103
intn-gpios = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */
104-
reset-gpios = <&pio 4 16 GPIO_ACTIVE_HIGH>; /* PE16 */
104+
reset-gpios = <&pio 4 16 GPIO_ACTIVE_LOW>; /* PE16 */
105105
connect-gpios = <&pio 4 17 GPIO_ACTIVE_HIGH>; /* PE17 */
106106
refclk-frequency = <19200000>;
107107
};

0 commit comments

Comments
 (0)