Skip to content

Commit 1c5e1cd

Browse files
jwrdegoederafaeljw
authored andcommitted
ACPI/PCI: pci_link: use extended_irq union member when setting ext-irq shareable
The case ACPI_RESOURCE_TYPE_EXTENDED_IRQ inside acpi_pci_link_set() is correctly using resource->res.data.extended_irq.foo for most settings, but for the shareable setting it so far has accidentally been using resource->res.data.irq.shareable instead of resource->res.data.extended_irq.shareable. Note that the old code happens to also work because the shareable field offset is the same for both the acpi_resource_irq and acpi_resource_extended_irq structs. Acked-by: Bjorn Helgaas <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent ae83d0b commit 1c5e1cd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/acpi/pci_link.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,10 +322,10 @@ static int acpi_pci_link_set(struct acpi_pci_link *link, int irq)
322322
resource->res.data.extended_irq.polarity =
323323
link->irq.polarity;
324324
if (link->irq.triggering == ACPI_EDGE_SENSITIVE)
325-
resource->res.data.irq.shareable =
325+
resource->res.data.extended_irq.shareable =
326326
ACPI_EXCLUSIVE;
327327
else
328-
resource->res.data.irq.shareable = ACPI_SHARED;
328+
resource->res.data.extended_irq.shareable = ACPI_SHARED;
329329
resource->res.data.extended_irq.interrupt_count = 1;
330330
resource->res.data.extended_irq.interrupts[0] = irq;
331331
/* ignore resource_source, it's optional */

0 commit comments

Comments
 (0)