Skip to content

Commit 1c8f80c

Browse files
committed
drm/i915/display: convert params to struct intel_display
Going forward, struct intel_display shall replace struct drm_i915_private as the main display device data pointer type. Convert intel_display_params.[ch] and intel_display_debugfs_params.[ch] to struct intel_display. Some stragglers are left behind where needed. Reviewed-by: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/3e5cc1744eaf4708b08303e3e7e194035d7941cc.1724342644.git.jani.nikula@intel.com Signed-off-by: Jani Nikula <[email protected]>
1 parent 065ca63 commit 1c8f80c

File tree

7 files changed

+16
-14
lines changed

7 files changed

+16
-14
lines changed

drivers/gpu/drm/i915/display/intel_display_debugfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1073,7 +1073,7 @@ void intel_display_debugfs_register(struct drm_i915_private *i915)
10731073
intel_opregion_debugfs_register(display);
10741074
intel_psr_debugfs_register(i915);
10751075
intel_wm_debugfs_register(i915);
1076-
intel_display_debugfs_params(i915);
1076+
intel_display_debugfs_params(display);
10771077
}
10781078

10791079
static int i915_hdcp_sink_capability_show(struct seq_file *m, void *data)

drivers/gpu/drm/i915/display/intel_display_debugfs_params.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,13 +151,13 @@ intel_display_debugfs_create_uint(const char *name, umode_t mode,
151151
} while (0)
152152

153153
/* add a subdirectory with files for each intel display param */
154-
void intel_display_debugfs_params(struct drm_i915_private *i915)
154+
void intel_display_debugfs_params(struct intel_display *display)
155155
{
156-
struct drm_minor *minor = i915->drm.primary;
156+
struct drm_minor *minor = display->drm->primary;
157157
struct dentry *dir;
158158
char dirname[16];
159159

160-
snprintf(dirname, sizeof(dirname), "%s_params", i915->drm.driver->name);
160+
snprintf(dirname, sizeof(dirname), "%s_params", display->drm->driver->name);
161161
dir = debugfs_lookup(dirname, minor->debugfs_root);
162162
if (!dir)
163163
dir = debugfs_create_dir(dirname, minor->debugfs_root);
@@ -171,7 +171,7 @@ void intel_display_debugfs_params(struct drm_i915_private *i915)
171171
*/
172172

173173
#define REGISTER(T, x, unused, mode, ...) _intel_display_param_create_file( \
174-
dir, #x, mode, &i915->display.params.x);
174+
dir, #x, mode, &display->params.x);
175175
INTEL_DISPLAY_PARAMS_FOR_EACH(REGISTER);
176176
#undef REGISTER
177177
}

drivers/gpu/drm/i915/display/intel_display_debugfs_params.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
#ifndef __INTEL_DISPLAY_DEBUGFS_PARAMS__
77
#define __INTEL_DISPLAY_DEBUGFS_PARAMS__
88

9-
struct drm_i915_private;
9+
struct intel_display;
1010

11-
void intel_display_debugfs_params(struct drm_i915_private *i915);
11+
void intel_display_debugfs_params(struct intel_display *display);
1212

1313
#endif /* __INTEL_DISPLAY_DEBUGFS_PARAMS__ */

drivers/gpu/drm/i915/display/intel_display_params.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,14 +173,14 @@ static void _param_print_charp(struct drm_printer *p, const char *driver_name,
173173

174174
/**
175175
* intel_display_params_dump - dump intel display modparams
176-
* @i915: i915 device
176+
* @display: display device
177177
* @p: the &drm_printer
178178
*
179179
* Pretty printer for i915 modparams.
180180
*/
181-
void intel_display_params_dump(struct drm_i915_private *i915, struct drm_printer *p)
181+
void intel_display_params_dump(struct intel_display *display, struct drm_printer *p)
182182
{
183-
#define PRINT(T, x, ...) _param_print(p, i915->drm.driver->name, #x, i915->display.params.x);
183+
#define PRINT(T, x, ...) _param_print(p, display->drm->driver->name, #x, display->params.x);
184184
INTEL_DISPLAY_PARAMS_FOR_EACH(PRINT);
185185
#undef PRINT
186186
}

drivers/gpu/drm/i915/display/intel_display_params.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include <linux/types.h>
1010

1111
struct drm_printer;
12-
struct drm_i915_private;
12+
struct intel_display;
1313

1414
/*
1515
* Invoke param, a function-like macro, for each intel display param, with
@@ -56,7 +56,7 @@ struct intel_display_params {
5656
};
5757
#undef MEMBER
5858

59-
void intel_display_params_dump(struct drm_i915_private *i915,
59+
void intel_display_params_dump(struct intel_display *display,
6060
struct drm_printer *p);
6161
void intel_display_params_copy(struct intel_display_params *dest);
6262
void intel_display_params_free(struct intel_display_params *params);

drivers/gpu/drm/i915/i915_debugfs.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ static inline struct drm_i915_private *node_to_i915(struct drm_info_node *node)
6666
static int i915_capabilities(struct seq_file *m, void *data)
6767
{
6868
struct drm_i915_private *i915 = node_to_i915(m->private);
69+
struct intel_display *display = &i915->display;
6970
struct drm_printer p = drm_seq_file_printer(m);
7071

7172
seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(i915));
@@ -77,7 +78,7 @@ static int i915_capabilities(struct seq_file *m, void *data)
7778

7879
kernel_param_lock(THIS_MODULE);
7980
i915_params_dump(&i915->params, &p);
80-
intel_display_params_dump(i915, &p);
81+
intel_display_params_dump(display, &p);
8182
kernel_param_unlock(THIS_MODULE);
8283

8384
return 0;

drivers/gpu/drm/i915/i915_gpu_error.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -660,9 +660,10 @@ static void err_print_params(struct drm_i915_error_state_buf *m,
660660
const struct i915_params *params)
661661
{
662662
struct drm_printer p = i915_error_printer(m);
663+
struct intel_display *display = &m->i915->display;
663664

664665
i915_params_dump(params, &p);
665-
intel_display_params_dump(m->i915, &p);
666+
intel_display_params_dump(display, &p);
666667
}
667668

668669
static void err_print_pciid(struct drm_i915_error_state_buf *m,

0 commit comments

Comments
 (0)