Skip to content

Commit 1cbf0a5

Browse files
Hugh Dickinsakpm00
authored andcommitted
ext4: add __GFP_NOWARN to GFP_NOWAIT in readahead
Since commit e509ad4 ("ext4: use bdev_getblk() to avoid memory reclaim in readahead path") rightly replaced GFP_NOFAIL allocations by GFP_NOWAIT allocations, I've occasionally been seeing "page allocation failure: order:0" warnings under load: all with ext4_sb_breadahead_unmovable() in the stack. I don't think those warnings are of any interest: suppress them with __GFP_NOWARN. Link: https://lkml.kernel.org/r/[email protected] Fixes: e509ad4 ("ext4: use bdev_getblk() to avoid memory reclaim in readahead path") Signed-off-by: Hugh Dickins <[email protected]> Reviewed-by: Jan Kara <[email protected]> Cc: Hui Zhu <[email protected]> Cc: Matthew Wilcox (Oracle) <[email protected]> Cc: Theodore Ts'o <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent eebb3da commit 1cbf0a5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/ext4/super.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ struct buffer_head *ext4_sb_bread_unmovable(struct super_block *sb,
262262
void ext4_sb_breadahead_unmovable(struct super_block *sb, sector_t block)
263263
{
264264
struct buffer_head *bh = bdev_getblk(sb->s_bdev, block,
265-
sb->s_blocksize, GFP_NOWAIT);
265+
sb->s_blocksize, GFP_NOWAIT | __GFP_NOWARN);
266266

267267
if (likely(bh)) {
268268
if (trylock_buffer(bh))

0 commit comments

Comments
 (0)