Skip to content

Commit 1ce50e7

Browse files
committed
thermal: core: genetlink support for events/cmd/sampling
Initially the thermal framework had a very simple notification mechanism to send generic netlink messages to the userspace. The notification function was never called from anywhere and the corresponding dead code was removed. It was probably a first attempt to introduce the netlink notification. At LPC2018, the presentation "Linux thermal: User kernel interface", proposed to create the notifications to the userspace via a kfifo. The advantage of the kfifo is the performance. It is usually used from a 1:1 communication channel where a driver captures data and sends it as fast as possible to a userspace process. The drawback is that only one process uses the notification channel exclusively, thus no other process is allowed to use the channel to get temperature or notifications. This patch defines a generic netlink API to discover the current thermal setup and adds event notifications as well as temperature sampling. As any genetlink protocol, it can evolve and the versioning allows to keep the backward compatibility. In order to prevent the user from getting flooded with data on a single channel, there are two multicast channels, one for the temperature sampling when the thermal zone is updated and another one for the events, so the user can get the events only without the thermal zone temperature sampling. Also, a list of commands to discover the thermal setup is added and can be extended when needed. Reviewed-by: Amit Kucheria <[email protected]> Signed-off-by: Daniel Lezcano <[email protected]> Acked-by: Zhang Rui <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 329b064 commit 1ce50e7

File tree

5 files changed

+739
-35
lines changed

5 files changed

+739
-35
lines changed

drivers/thermal/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
obj-$(CONFIG_THERMAL) += thermal_sys.o
77
thermal_sys-y += thermal_core.o thermal_sysfs.o \
8-
thermal_helpers.o
8+
thermal_helpers.o thermal_netlink.o
99

1010
# interface to/from other layers providing sensors
1111
thermal_sys-$(CONFIG_THERMAL_HWMON) += thermal_hwmon.o

drivers/thermal/thermal_core.h

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,24 @@ int for_each_thermal_governor(int (*cb)(struct thermal_governor *, void *),
5252

5353
struct thermal_zone_device *thermal_zone_get_by_id(int id);
5454

55+
/* Netlink notification function */
56+
int thermal_notify_tz_create(int tz_id, const char *name);
57+
int thermal_notify_tz_delete(int tz_id);
58+
int thermal_notify_tz_enable(int tz_id);
59+
int thermal_notify_tz_disable(int tz_id);
60+
int thermal_notify_tz_trip_down(int tz_id, int id);
61+
int thermal_notify_tz_trip_up(int tz_id, int id);
62+
int thermal_notify_tz_trip_delete(int tz_id, int id);
63+
int thermal_notify_tz_trip_add(int tz_id, int id, int type,
64+
int temp, int hyst);
65+
int thermal_notify_tz_trip_change(int tz_id, int id, int type,
66+
int temp, int hyst);
67+
int thermal_notify_cdev_state_update(int cdev_id, int state);
68+
int thermal_notify_cdev_add(int cdev_id, const char *name, int max_state);
69+
int thermal_notify_cdev_delete(int cdev_id);
70+
int thermal_notify_tz_gov_change(int tz_id, const char *name);
71+
int thermal_genl_sampling_temp(int id, int temp);
72+
5573
struct thermal_attr {
5674
struct device_attribute attr;
5775
char name[THERMAL_NAME_LENGTH];

0 commit comments

Comments
 (0)