Skip to content

Commit 1d0c1aa

Browse files
Fabrice GasnierAlexandre Torgue
authored andcommitted
ARM: dts: stm32: add missing usbh clock and fix clk order on stm32mp15
The USBH composed of EHCI and OHCI controllers needs the PHY clock to be initialized first, before enabling (gating) them. The reverse is also required when going to suspend. So, add USBPHY clock as 1st entry in both controllers, so the USBPHY PLL gets enabled 1st upon controller init. Upon suspend/resume, this also makes the clock to be disabled/re-enabled in the correct order. This fixes some IRQ storm conditions seen when going to low-power, due to PHY PLL being disabled before all clocks are cleanly gated. Fixes: 949a0c0 ("ARM: dts: stm32: add USB Host (USBH) support to stm32mp157c") Fixes: db7be2c ("ARM: dts: stm32: use usbphyc ck_usbo_48m as USBH OHCI clock on stm32mp151") Signed-off-by: Fabrice Gasnier <[email protected]> Signed-off-by: Alexandre Torgue <[email protected]>
1 parent bf74181 commit 1d0c1aa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/arm/boot/dts/stm32mp151.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1474,7 +1474,7 @@
14741474
usbh_ohci: usb@5800c000 {
14751475
compatible = "generic-ohci";
14761476
reg = <0x5800c000 0x1000>;
1477-
clocks = <&rcc USBH>, <&usbphyc>;
1477+
clocks = <&usbphyc>, <&rcc USBH>;
14781478
resets = <&rcc USBH_R>;
14791479
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
14801480
status = "disabled";
@@ -1483,7 +1483,7 @@
14831483
usbh_ehci: usb@5800d000 {
14841484
compatible = "generic-ehci";
14851485
reg = <0x5800d000 0x1000>;
1486-
clocks = <&rcc USBH>;
1486+
clocks = <&usbphyc>, <&rcc USBH>;
14871487
resets = <&rcc USBH_R>;
14881488
interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
14891489
companion = <&usbh_ohci>;

0 commit comments

Comments
 (0)