Skip to content

Commit 1d5d166

Browse files
maciej-w-rozyckibjorn-helgaas
authored andcommitted
MIPS: Malta: Fix PCI southbridge legacy resource reservations
Covering the PCI southbridge legacy port I/O range with a northbridge resource reservation prevents MIPS Malta platform code from claiming its standard legacy resources. This is because request_resource() calls cause a clash with the previous reservation and consequently fail. Change to using insert_resource() so as to prevent the clash, switching the legacy reservations from: 00000000-00ffffff : MSC PCI I/O 00000020-00000021 : pic1 00000070-00000077 : rtc0 000000a0-000000a1 : pic2 [...] to: 00000000-00ffffff : MSC PCI I/O 00000000-0000001f : dma1 00000020-00000021 : pic1 00000040-0000005f : timer 00000060-0000006f : keyboard 00000070-00000077 : rtc0 00000080-0000008f : dma page reg 000000a0-000000a1 : pic2 000000c0-000000df : dma2 [...] Fixes: ae81aad ("MIPS: PCI: Use pci_enable_resources()") Signed-off-by: Maciej W. Rozycki <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Ilpo Järvinen <[email protected]> Acked-by: Thomas Bogendoerfer <[email protected]> Cc: [email protected] # v6.18+ Link: https://patch.msgid.link/[email protected]
1 parent bf55705 commit 1d5d166

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/mips/mti-malta/malta-setup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ void __init plat_mem_setup(void)
213213

214214
/* Request I/O space for devices used on the Malta board. */
215215
for (i = 0; i < ARRAY_SIZE(standard_io_resources); i++)
216-
request_resource(&ioport_resource, standard_io_resources+i);
216+
insert_resource(&ioport_resource, standard_io_resources + i);
217217

218218
/*
219219
* Enable DMA channel 4 (cascade channel) in the PIIX4 south bridge.

0 commit comments

Comments
 (0)