Skip to content

Commit 1d5f022

Browse files
committed
ftrace: Declare function_trace_op in header to quiet sparse warning
Sparse complains that function_trace_op is not static but is not declared in a header file. It is used only in assembly code. But add it to a header so that sparse no longer complains: kernel/trace/ftrace.c:99:19: warning: symbol 'function_trace_op' was not declared. Should it be static? Link: https://lore.kernel.org/linux-trace-kernel/[email protected] Cc: Mark Rutland <[email protected]> Cc: Mathieu Desnoyers <[email protected]> Cc: Andrew Morton <[email protected]> Acked-by: Masami Hiramatsu (Google) <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent d66bb33 commit 1d5f022

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

include/linux/ftrace.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1131,6 +1131,9 @@ extern void ftrace_graph_init_task(struct task_struct *t);
11311131
extern void ftrace_graph_exit_task(struct task_struct *t);
11321132
extern void ftrace_graph_init_idle_task(struct task_struct *t, int cpu);
11331133

1134+
/* Used by assembly, but to quiet sparse warnings */
1135+
extern struct ftrace_ops *function_trace_op;
1136+
11341137
static inline void pause_graph_tracing(void)
11351138
{
11361139
atomic_inc(&current->tracing_graph_pause);

0 commit comments

Comments
 (0)