Skip to content

Commit 1d8e64f

Browse files
mwalleambarus
authored andcommitted
mtd: spi-nor: gigadevice: sort flash_info database
The flash ID is the new primary key into our database. Sort the entry by it. Keep the most specific ones first, because there might be ID collisions between shorter and longer ones. Signed-off-by: Michael Walle <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Tudor Ambarus <[email protected]>
1 parent bc16dfc commit 1d8e64f

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

drivers/mtd/spi-nor/gigadevice.c

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -46,30 +46,12 @@ static const struct flash_info gigadevice_nor_parts[] = {
4646
.size = SZ_4M,
4747
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
4848
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
49-
}, {
50-
.id = SNOR_ID(0xc8, 0x60, 0x16),
51-
.name = "gd25lq32",
52-
.size = SZ_4M,
53-
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
54-
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
5549
}, {
5650
.id = SNOR_ID(0xc8, 0x40, 0x17),
5751
.name = "gd25q64",
5852
.size = SZ_8M,
5953
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
6054
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
61-
}, {
62-
.id = SNOR_ID(0xc8, 0x60, 0x17),
63-
.name = "gd25lq64c",
64-
.size = SZ_8M,
65-
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
66-
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
67-
}, {
68-
.id = SNOR_ID(0xc8, 0x60, 0x18),
69-
.name = "gd25lq128d",
70-
.size = SZ_16M,
71-
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
72-
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
7355
}, {
7456
.id = SNOR_ID(0xc8, 0x40, 0x18),
7557
.name = "gd25q128",
@@ -82,6 +64,24 @@ static const struct flash_info gigadevice_nor_parts[] = {
8264
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6,
8365
.fixups = &gd25q256_fixups,
8466
.fixup_flags = SPI_NOR_4B_OPCODES,
67+
}, {
68+
.id = SNOR_ID(0xc8, 0x60, 0x16),
69+
.name = "gd25lq32",
70+
.size = SZ_4M,
71+
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
72+
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
73+
}, {
74+
.id = SNOR_ID(0xc8, 0x60, 0x17),
75+
.name = "gd25lq64c",
76+
.size = SZ_8M,
77+
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
78+
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
79+
}, {
80+
.id = SNOR_ID(0xc8, 0x60, 0x18),
81+
.name = "gd25lq128d",
82+
.size = SZ_16M,
83+
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
84+
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
8585
},
8686
};
8787

0 commit comments

Comments
 (0)