Skip to content

Commit 1d9e13e

Browse files
ihex.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]>
1 parent 0ead336 commit 1d9e13e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/ihex.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
struct ihex_binrec {
1919
__be32 addr;
2020
__be16 len;
21-
uint8_t data[0];
21+
uint8_t data[];
2222
} __attribute__((packed));
2323

2424
static inline uint16_t ihex_binrec_size(const struct ihex_binrec *p)

0 commit comments

Comments
 (0)