Skip to content

Commit 1dae7e0

Browse files
adam900710kdave
authored andcommitted
btrfs: reloc: clear DEAD_RELOC_TREE bit for orphan roots to prevent runaway balance
[BUG] There are several reported runaway balance, that balance is flooding the log with "found X extents" where the X never changes. [CAUSE] Commit d2311e6 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots") introduced BTRFS_ROOT_DEAD_RELOC_TREE bit to indicate that one subvolume has finished its tree blocks swap with its reloc tree. However if balance is canceled or hits ENOSPC halfway, we didn't clear the BTRFS_ROOT_DEAD_RELOC_TREE bit, leaving that bit hanging forever until unmount. Any subvolume root with that bit, would cause backref cache to skip this tree block, as it has finished its tree block swap. This would cause all tree blocks of that root be ignored by balance, leading to runaway balance. [FIX] Fix the problem by also clearing the BTRFS_ROOT_DEAD_RELOC_TREE bit for the original subvolume of orphan reloc root. Add an umount check for the stale bit still set. Fixes: d2311e6 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots") Signed-off-by: Qu Wenruo <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent 51415b6 commit 1dae7e0

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

fs/btrfs/disk-io.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1994,6 +1994,7 @@ void btrfs_put_root(struct btrfs_root *root)
19941994

19951995
if (refcount_dec_and_test(&root->refs)) {
19961996
WARN_ON(!RB_EMPTY_ROOT(&root->inode_tree));
1997+
WARN_ON(test_bit(BTRFS_ROOT_DEAD_RELOC_TREE, &root->state));
19971998
if (root->anon_dev)
19981999
free_anon_bdev(root->anon_dev);
19992000
btrfs_drew_lock_destroy(&root->snapshot_lock);

fs/btrfs/relocation.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1935,6 +1935,8 @@ void merge_reloc_roots(struct reloc_control *rc)
19351935
root->reloc_root = NULL;
19361936
btrfs_put_root(reloc_root);
19371937
}
1938+
clear_bit(BTRFS_ROOT_DEAD_RELOC_TREE,
1939+
&root->state);
19381940
btrfs_put_root(root);
19391941
}
19401942

0 commit comments

Comments
 (0)