Skip to content

Commit 1e474b2

Browse files
paulmckrcuKAGA-KOKO
authored andcommitted
smp/up: Make smp_call_function_single() match SMP semantics
In CONFIG_SMP=y kernels, smp_call_function_single() returns -ENXIO when invoked for a non-existent CPU. In contrast, in CONFIG_SMP=n kernels, a splat is emitted and smp_call_function_single() otherwise silently ignores its "cpu" argument, instead pretending that the caller intended to have something happen on CPU 0. Given that there is now code that expects smp_call_function_single() to return an error if a bad CPU was specified, this difference in semantics needs to be addressed. Bring the semantics of the CONFIG_SMP=n version of smp_call_function_single() into alignment with its CONFIG_SMP=y counterpart. Signed-off-by: Paul E. McKenney <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Link: https://lkml.kernel.org/r/20200205143409.GA7021@paulmck-ThinkPad-P72
1 parent 25a3a15 commit 1e474b2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

kernel/up.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ int smp_call_function_single(int cpu, void (*func) (void *info), void *info,
1414
{
1515
unsigned long flags;
1616

17-
WARN_ON(cpu != 0);
17+
if (cpu != 0)
18+
return -ENXIO;
1819

1920
local_irq_save(flags);
2021
func(info);

0 commit comments

Comments
 (0)