Skip to content

Commit 1e81dcc

Browse files
vcgomesanguy11
authored andcommitted
igc: Do not enable crosstimestamping for i225-V models
It was reported that when PCIe PTM is enabled, some lockups could be observed with some integrated i225-V models. While the issue is investigated, we can disable crosstimestamp for those models and see no loss of functionality, because those models don't have any support for time synchronization. Fixes: a90ec84 ("igc: Add support for PTP getcrosststamp()") Link: https://lore.kernel.org/all/[email protected]/ Reported-by: Stefan Dietrich <[email protected]> Signed-off-by: Vinicius Costa Gomes <[email protected]> Tested-by: Nechama Kraus <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 16fa29a commit 1e81dcc

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

drivers/net/ethernet/intel/igc/igc_ptp.c

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,20 @@ int igc_ptp_get_ts_config(struct net_device *netdev, struct ifreq *ifr)
768768
*/
769769
static bool igc_is_crosststamp_supported(struct igc_adapter *adapter)
770770
{
771-
return IS_ENABLED(CONFIG_X86_TSC) ? pcie_ptm_enabled(adapter->pdev) : false;
771+
if (!IS_ENABLED(CONFIG_X86_TSC))
772+
return false;
773+
774+
/* FIXME: it was noticed that enabling support for PCIe PTM in
775+
* some i225-V models could cause lockups when bringing the
776+
* interface up/down. There should be no downsides to
777+
* disabling crosstimestamping support for i225-V, as it
778+
* doesn't have any PTP support. That way we gain some time
779+
* while root causing the issue.
780+
*/
781+
if (adapter->pdev->device == IGC_DEV_ID_I225_V)
782+
return false;
783+
784+
return pcie_ptm_enabled(adapter->pdev);
772785
}
773786

774787
static struct system_counterval_t igc_device_tstamp_to_system(u64 tstamp)

0 commit comments

Comments
 (0)