Skip to content

Commit 1e9cb7e

Browse files
krzkJassiBrar
authored andcommitted
dt-bindings: mailbox: qcom,apcs-kpss-global: use fallbacks
Rework the compatibles and group devices which have similar interface (same from Linux driver point of view) as compatible. This allows smaller of_device_id table in the Linux driver and smaller allOf:if:then: constraints. Signed-off-by: Krzysztof Kozlowski <[email protected]> Acked-by: Rob Herring <[email protected]> Signed-off-by: Jassi Brar <[email protected]>
1 parent 24583bd commit 1e9cb7e

File tree

1 file changed

+43
-18
lines changed

1 file changed

+43
-18
lines changed

Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml

Lines changed: 43 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,24 @@ properties:
2323
- qcom,ipq8074-apcs-apps-global
2424
- qcom,ipq9574-apcs-apps-global
2525
- const: qcom,ipq6018-apcs-apps-global
26+
- items:
27+
- enum:
28+
- qcom,qcs404-apcs-apps-global
29+
- const: qcom,msm8916-apcs-kpss-global
30+
- const: syscon
31+
- items:
32+
- enum:
33+
- qcom,msm8976-apcs-kpss-global
34+
- const: qcom,msm8994-apcs-kpss-global
35+
- const: syscon
36+
- items:
37+
- enum:
38+
- qcom,msm8998-apcs-hmss-global
39+
- qcom,sdm660-apcs-hmss-global
40+
- qcom,sm4250-apcs-hmss-global
41+
- qcom,sm6115-apcs-hmss-global
42+
- qcom,sm6125-apcs-hmss-global
43+
- const: qcom,msm8994-apcs-kpss-global
2644
- items:
2745
- enum:
2846
- qcom,sc7180-apss-shared
@@ -34,21 +52,14 @@ properties:
3452
- qcom,msm8916-apcs-kpss-global
3553
- qcom,msm8939-apcs-kpss-global
3654
- qcom,msm8953-apcs-kpss-global
37-
- qcom,msm8976-apcs-kpss-global
3855
- qcom,msm8994-apcs-kpss-global
39-
- qcom,qcs404-apcs-apps-global
4056
- qcom,sdx55-apcs-gcc
4157
- const: syscon
4258
- enum:
4359
- qcom,ipq6018-apcs-apps-global
4460
- qcom,msm8996-apcs-hmss-global
45-
- qcom,msm8998-apcs-hmss-global
4661
- qcom,qcm2290-apcs-hmss-global
47-
- qcom,sdm660-apcs-hmss-global
4862
- qcom,sdm845-apss-shared
49-
- qcom,sm4250-apcs-hmss-global
50-
- qcom,sm6115-apcs-hmss-global
51-
- qcom,sm6125-apcs-hmss-global
5263

5364
reg:
5465
maxItems: 1
@@ -79,20 +90,38 @@ allOf:
7990
- if:
8091
properties:
8192
compatible:
82-
enum:
83-
- qcom,msm8916-apcs-kpss-global
84-
- qcom,msm8939-apcs-kpss-global
85-
- qcom,qcs404-apcs-apps-global
93+
contains:
94+
enum:
95+
- qcom,msm8916-apcs-kpss-global
96+
then:
97+
properties:
98+
clocks:
99+
items:
100+
- description: primary pll parent of the clock driver
101+
- description: auxiliary parent
102+
clock-names:
103+
items:
104+
- const: pll
105+
- const: aux
106+
107+
- if:
108+
properties:
109+
compatible:
110+
contains:
111+
enum:
112+
- qcom,msm8939-apcs-kpss-global
86113
then:
87114
properties:
88115
clocks:
89116
items:
90117
- description: primary pll parent of the clock driver
91118
- description: auxiliary parent
119+
- description: reference clock
92120
clock-names:
93121
items:
94122
- const: pll
95123
- const: aux
124+
- const: ref
96125

97126
- if:
98127
properties:
@@ -112,6 +141,7 @@ allOf:
112141
- const: ref
113142
- const: pll
114143
- const: aux
144+
115145
- if:
116146
properties:
117147
compatible:
@@ -136,16 +166,10 @@ allOf:
136166
compatible:
137167
enum:
138168
- qcom,msm8953-apcs-kpss-global
139-
- qcom,msm8976-apcs-kpss-global
140169
- qcom,msm8994-apcs-kpss-global
141170
- qcom,msm8996-apcs-hmss-global
142-
- qcom,msm8998-apcs-hmss-global
143171
- qcom,qcm2290-apcs-hmss-global
144-
- qcom,sdm660-apcs-hmss-global
145172
- qcom,sdm845-apss-shared
146-
- qcom,sm4250-apcs-hmss-global
147-
- qcom,sm6115-apcs-hmss-global
148-
- qcom,sm6125-apcs-hmss-global
149173
then:
150174
properties:
151175
clocks: false
@@ -191,7 +215,8 @@ examples:
191215
#define GCC_APSS_AHB_CLK_SRC 1
192216
#define GCC_GPLL0_AO_OUT_MAIN 123
193217
apcs: mailbox@b011000 {
194-
compatible = "qcom,qcs404-apcs-apps-global", "syscon";
218+
compatible = "qcom,qcs404-apcs-apps-global",
219+
"qcom,msm8916-apcs-kpss-global", "syscon";
195220
reg = <0x0b011000 0x1000>;
196221
#mbox-cells = <1>;
197222
clocks = <&apcs_hfpll>, <&gcc GCC_GPLL0_AO_OUT_MAIN>;

0 commit comments

Comments
 (0)