Skip to content

Commit 1ea3fd1

Browse files
committed
hwmon: (max6697) Fix swapped temp{1,8} critical alarms
The critical alarm bit for the local temperature sensor (temp1) is in bit 7 of register 0x45 (not bit 6), and the critical alarm bit for remote temperature sensor 7 (temp8) is in bit 6 (not bit 7). This only affects MAX6581 since all other chips supported by this driver do not support those critical alarms. Fixes: 5372d2d ("hwmon: Driver for Maxim MAX6697 and compatibles") Reviewed-by: Tzung-Bi Shih <[email protected]> Signed-off-by: Guenter Roeck <[email protected]>
1 parent cbf7467 commit 1ea3fd1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/hwmon/max6697.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -429,14 +429,14 @@ static SENSOR_DEVICE_ATTR_RO(temp6_max_alarm, alarm, 20);
429429
static SENSOR_DEVICE_ATTR_RO(temp7_max_alarm, alarm, 21);
430430
static SENSOR_DEVICE_ATTR_RO(temp8_max_alarm, alarm, 23);
431431

432-
static SENSOR_DEVICE_ATTR_RO(temp1_crit_alarm, alarm, 14);
432+
static SENSOR_DEVICE_ATTR_RO(temp1_crit_alarm, alarm, 15);
433433
static SENSOR_DEVICE_ATTR_RO(temp2_crit_alarm, alarm, 8);
434434
static SENSOR_DEVICE_ATTR_RO(temp3_crit_alarm, alarm, 9);
435435
static SENSOR_DEVICE_ATTR_RO(temp4_crit_alarm, alarm, 10);
436436
static SENSOR_DEVICE_ATTR_RO(temp5_crit_alarm, alarm, 11);
437437
static SENSOR_DEVICE_ATTR_RO(temp6_crit_alarm, alarm, 12);
438438
static SENSOR_DEVICE_ATTR_RO(temp7_crit_alarm, alarm, 13);
439-
static SENSOR_DEVICE_ATTR_RO(temp8_crit_alarm, alarm, 15);
439+
static SENSOR_DEVICE_ATTR_RO(temp8_crit_alarm, alarm, 14);
440440

441441
static SENSOR_DEVICE_ATTR_RO(temp2_fault, alarm, 1);
442442
static SENSOR_DEVICE_ATTR_RO(temp3_fault, alarm, 2);

0 commit comments

Comments
 (0)