Skip to content

Commit 1eb9112

Browse files
palistorulf
authored andcommitted
mmc: sdio: Fix Cypress SDIO IDs macros in common include file
All macro names for SDIO device IDs are prefixed by vendor name to which device ID belongs. So for consistency add Broadcom string vendor prefix to all Cypress macro names as they belong to SDIO Broadcom vendor ID. Change also Cypress 43012 value from decimal do hexadecimal notation to be consistent with all other values. Signed-off-by: Pali Rohár <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ulf Hansson <[email protected]>
1 parent 8baa6d1 commit 1eb9112

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -970,9 +970,9 @@ static const struct sdio_device_id brcmf_sdmmc_ids[] = {
970970
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4354),
971971
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4356),
972972
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4359),
973-
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_CYPRESS_4373),
974-
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_CYPRESS_43012),
975-
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_CYPRESS_89359),
973+
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373),
974+
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_43012),
975+
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_89359),
976976
{ /* end: all zeroes */ }
977977
};
978978
MODULE_DEVICE_TABLE(sdio, brcmf_sdmmc_ids);

drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4187,7 +4187,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err,
41874187
bus->hostintmask, NULL);
41884188

41894189
switch (sdiod->func1->device) {
4190-
case SDIO_DEVICE_ID_CYPRESS_4373:
4190+
case SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373:
41914191
brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes\n",
41924192
CY_4373_F2_WATERMARK);
41934193
brcmf_sdiod_writeb(sdiod, SBSDIO_WATERMARK,
@@ -4201,7 +4201,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err,
42014201
CY_4373_F2_WATERMARK |
42024202
SBSDIO_MESBUSYCTRL_ENAB, &err);
42034203
break;
4204-
case SDIO_DEVICE_ID_CYPRESS_43012:
4204+
case SDIO_DEVICE_ID_BROADCOM_CYPRESS_43012:
42054205
brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes\n",
42064206
CY_43012_F2_WATERMARK);
42074207
brcmf_sdiod_writeb(sdiod, SBSDIO_WATERMARK,

include/linux/mmc/sdio_ids.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@
5858
#define SDIO_DEVICE_ID_BROADCOM_4354 0x4354
5959
#define SDIO_DEVICE_ID_BROADCOM_4356 0x4356
6060
#define SDIO_DEVICE_ID_BROADCOM_4359 0x4359
61-
#define SDIO_DEVICE_ID_CYPRESS_4373 0x4373
62-
#define SDIO_DEVICE_ID_CYPRESS_43012 43012
63-
#define SDIO_DEVICE_ID_CYPRESS_89359 0x4355
61+
#define SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373 0x4373
62+
#define SDIO_DEVICE_ID_BROADCOM_CYPRESS_43012 0xa804
63+
#define SDIO_DEVICE_ID_BROADCOM_CYPRESS_89359 0x4355
6464

6565
#define SDIO_VENDOR_ID_INTEL 0x0089
6666
#define SDIO_DEVICE_ID_INTEL_IWMC3200WIMAX 0x1402

0 commit comments

Comments
 (0)