Skip to content

Commit 1f00647

Browse files
mattropeThomas Hellström
authored andcommitted
drm/xe/mcr: Avoid clobbering DSS steering
A couple copy/paste mistakes in the code that selects steering targets for OADDRM and INSTANCE0 unintentionally clobbered the steering target for DSS ranges in some cases. The OADDRM/INSTANCE0 values were also not assigned as intended, although that mistake wound up being harmless since the desired values for those specific ranges were '0' which the kzalloc of the GT structure should have already taken care of implicitly. Fixes: dd08ebf ("drm/xe: Introduce a new DRM driver for Intel GPUs") Signed-off-by: Matt Roper <[email protected]> Reviewed-by: Lucas De Marchi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit 4f82ac6) Signed-off-by: Thomas Hellström <[email protected]>
1 parent fc932f5 commit 1f00647

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/gpu/drm/xe/xe_gt_mcr.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ static void init_steering_oaddrm(struct xe_gt *gt)
342342
else
343343
gt->steering[OADDRM].group_target = 1;
344344

345-
gt->steering[DSS].instance_target = 0; /* unused */
345+
gt->steering[OADDRM].instance_target = 0; /* unused */
346346
}
347347

348348
static void init_steering_sqidi_psmi(struct xe_gt *gt)
@@ -357,8 +357,8 @@ static void init_steering_sqidi_psmi(struct xe_gt *gt)
357357

358358
static void init_steering_inst0(struct xe_gt *gt)
359359
{
360-
gt->steering[DSS].group_target = 0; /* unused */
361-
gt->steering[DSS].instance_target = 0; /* unused */
360+
gt->steering[INSTANCE0].group_target = 0; /* unused */
361+
gt->steering[INSTANCE0].instance_target = 0; /* unused */
362362
}
363363

364364
static const struct {

0 commit comments

Comments
 (0)