Skip to content

Commit 1f34b5a

Browse files
Bartosz Golaszewskikrzk
authored andcommitted
memory: omap-gpmc: remove GPIO set() and direction_output() callbacks
This driver implements an input-only GPIO controller. There's no need to implement the set() and direction_output() callbacks in this case, the GPIO core will handle it. Signed-off-by: Bartosz Golaszewski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Krzysztof Kozlowski <[email protected]>
1 parent a63f990 commit 1f34b5a

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

drivers/memory/omap-gpmc.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2385,17 +2385,6 @@ static int gpmc_gpio_direction_input(struct gpio_chip *chip,
23852385
return 0; /* we're input only */
23862386
}
23872387

2388-
static int gpmc_gpio_direction_output(struct gpio_chip *chip,
2389-
unsigned int offset, int value)
2390-
{
2391-
return -EINVAL; /* we're input only */
2392-
}
2393-
2394-
static void gpmc_gpio_set(struct gpio_chip *chip, unsigned int offset,
2395-
int value)
2396-
{
2397-
}
2398-
23992388
static int gpmc_gpio_get(struct gpio_chip *chip, unsigned int offset)
24002389
{
24012390
u32 reg;
@@ -2417,8 +2406,6 @@ static int gpmc_gpio_init(struct gpmc_device *gpmc)
24172406
gpmc->gpio_chip.ngpio = gpmc_nr_waitpins;
24182407
gpmc->gpio_chip.get_direction = gpmc_gpio_get_direction;
24192408
gpmc->gpio_chip.direction_input = gpmc_gpio_direction_input;
2420-
gpmc->gpio_chip.direction_output = gpmc_gpio_direction_output;
2421-
gpmc->gpio_chip.set = gpmc_gpio_set;
24222409
gpmc->gpio_chip.get = gpmc_gpio_get;
24232410
gpmc->gpio_chip.base = -1;
24242411

0 commit comments

Comments
 (0)