Skip to content

Commit 1fc62c8

Browse files
konradybcioandersson
authored andcommitted
clk: qcom: mmcc-msm8998: Fix the SMMU GDSC
The SMMU GDSC doesn't have to be ALWAYS-ON and shouldn't feature the HW_CTRL flag (it's separate from hw_ctrl_addr). In addition to that, it should feature a cxc entry for bimc_smmu_axi_clk and be marked as votable. Fix all of these issues. Fixes: d14b15b ("clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver") Signed-off-by: Konrad Dybcio <[email protected]> Reviewed-by: Jeffrey Hugo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 9906c41 commit 1fc62c8

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/clk/qcom/mmcc-msm8998.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2610,11 +2610,13 @@ static struct gdsc camss_cpp_gdsc = {
26102610
static struct gdsc bimc_smmu_gdsc = {
26112611
.gdscr = 0xe020,
26122612
.gds_hw_ctrl = 0xe024,
2613+
.cxcs = (unsigned int []){ 0xe008 },
2614+
.cxc_count = 1,
26132615
.pd = {
26142616
.name = "bimc_smmu",
26152617
},
26162618
.pwrsts = PWRSTS_OFF_ON,
2617-
.flags = HW_CTRL | ALWAYS_ON,
2619+
.flags = VOTABLE,
26182620
};
26192621

26202622
static struct clk_regmap *mmcc_msm8998_clocks[] = {

0 commit comments

Comments
 (0)