Skip to content

Commit 1fca58f

Browse files
Uwe Kleine-KönigTzung-Bi Shih
authored andcommitted
platform/chrome/wilco_ec: debugfs: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Tzung-Bi Shih <[email protected]>
1 parent 4864850 commit 1fca58f

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/platform/chrome/wilco_ec/debugfs.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,19 +260,17 @@ static int wilco_ec_debugfs_probe(struct platform_device *pdev)
260260
return 0;
261261
}
262262

263-
static int wilco_ec_debugfs_remove(struct platform_device *pdev)
263+
static void wilco_ec_debugfs_remove(struct platform_device *pdev)
264264
{
265265
debugfs_remove_recursive(debug_info->dir);
266-
267-
return 0;
268266
}
269267

270268
static struct platform_driver wilco_ec_debugfs_driver = {
271269
.driver = {
272270
.name = DRV_NAME,
273271
},
274272
.probe = wilco_ec_debugfs_probe,
275-
.remove = wilco_ec_debugfs_remove,
273+
.remove_new = wilco_ec_debugfs_remove,
276274
};
277275

278276
module_platform_driver(wilco_ec_debugfs_driver);

0 commit comments

Comments
 (0)