Skip to content

Commit 2008d89

Browse files
xen0nliu-song-6
authored andcommitted
raid6: test: cosmetic cleanups for the test Makefile
Use tabs/spaces consistently: hard tabs for marking recipe lines only, spaces for everything else. Also, the OPTFLAGS declaration actually included the tabs preceding the line comment, making compiler invocation lines unnecessarily long. As the entire block of declarations are meant for ad-hoc customization (otherwise they would probably make use of `?=` instead of `=`), move the "Adjust as desired" comment above the block too to fix the long invocation lines. Signed-off-by: WANG Xuerui <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Song Liu <[email protected]>
1 parent 9dd6e1d commit 2008d89

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

lib/raid6/test/Makefile

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,15 @@
66

77
pound := \#
88

9-
CC = gcc
10-
OPTFLAGS = -O2 # Adjust as desired
11-
CFLAGS = -I.. -I ../../../include -g $(OPTFLAGS)
12-
LD = ld
13-
AWK = awk -f
14-
AR = ar
15-
RANLIB = ranlib
16-
OBJS = int1.o int2.o int4.o int8.o int16.o int32.o recov.o algos.o tables.o
9+
# Adjust as desired
10+
CC = gcc
11+
OPTFLAGS = -O2
12+
CFLAGS = -I.. -I ../../../include -g $(OPTFLAGS)
13+
LD = ld
14+
AWK = awk -f
15+
AR = ar
16+
RANLIB = ranlib
17+
OBJS = int1.o int2.o int4.o int8.o int16.o int32.o recov.o algos.o tables.o
1718

1819
ARCH := $(shell uname -m 2>/dev/null | sed -e /s/i.86/i386/)
1920
ifeq ($(ARCH),i386)
@@ -37,9 +38,9 @@ endif
3738
ifeq ($(IS_X86),yes)
3839
OBJS += mmx.o sse1.o sse2.o avx2.o recov_ssse3.o recov_avx2.o avx512.o recov_avx512.o
3940
CFLAGS += -DCONFIG_X86
40-
CFLAGS += $(shell echo "vpmovm2b %k1, %zmm5" | \
41-
gcc -c -x assembler - >/dev/null 2>&1 && \
42-
rm ./-.o && echo -DCONFIG_AS_AVX512=1)
41+
CFLAGS += $(shell echo "vpmovm2b %k1, %zmm5" | \
42+
gcc -c -x assembler - >/dev/null 2>&1 && \
43+
rm ./-.o && echo -DCONFIG_AS_AVX512=1)
4344
else ifeq ($(HAS_NEON),yes)
4445
OBJS += neon.o neon1.o neon2.o neon4.o neon8.o recov_neon.o recov_neon_inner.o
4546
CFLAGS += -DCONFIG_KERNEL_MODE_NEON=1
@@ -63,12 +64,12 @@ endif
6364
%.uc: ../%.uc
6465
cp -f $< $@
6566

66-
all: raid6.a raid6test
67+
all: raid6.a raid6test
6768

6869
raid6.a: $(OBJS)
69-
rm -f $@
70-
$(AR) cq $@ $^
71-
$(RANLIB) $@
70+
rm -f $@
71+
$(AR) cq $@ $^
72+
$(RANLIB) $@
7273

7374
raid6test: test.c raid6.a
7475
$(CC) $(CFLAGS) -o raid6test $^

0 commit comments

Comments
 (0)