Skip to content

Commit 2042058

Browse files
Yellow-Paysre
authored andcommitted
power: supply: sc27xx: Replace devm_add_action() followed by failure action with devm_add_action_or_reset()
devm_add_action_or_reset() is introduced as a helper function which internally calls devm_add_action(). If devm_add_action() fails then it will execute the action mentioned and return the error code. This reduce source code size (avoid writing the action twice) and reduce the likelyhood of bugs. Signed-off-by: Fuqian Huang <[email protected]> Reviewed-by: Baolin Wang <[email protected]> Signed-off-by: Sebastian Reichel <[email protected]>
1 parent 08614b4 commit 2042058

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/power/supply/sc27xx_fuel_gauge.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1023,9 +1023,8 @@ static int sc27xx_fgu_probe(struct platform_device *pdev)
10231023
return ret;
10241024
}
10251025

1026-
ret = devm_add_action(dev, sc27xx_fgu_disable, data);
1026+
ret = devm_add_action_or_reset(dev, sc27xx_fgu_disable, data);
10271027
if (ret) {
1028-
sc27xx_fgu_disable(data);
10291028
dev_err(dev, "failed to add fgu disable action\n");
10301029
return ret;
10311030
}

0 commit comments

Comments
 (0)