Skip to content

Commit 20bb0c8

Browse files
chelsiocudbgdavem330
authored andcommitted
cxgb4vf: update kernel-doc line comments
Update several kernel-doc line comments to fix warnings reported by make W=1. Fixes following class of warnings reported by make W=1 in several places: cxgb4vf_main.c:275: warning: Function parameter or member 'persistent' not described in 'cxgb4vf_change_mac' cxgb4vf_main.c:275: warning: Excess function parameter 'persist' description in 'cxgb4vf_change_mac' Fixes: 16f8bd4 ("cxgb4vf: Add core T4 PCI-E SR-IOV Virtual Function hardware definitions and device communication code") Fixes: c6e0d91 ("cxgb4vf: Add T4 Virtual Function Scatter-Gather Engine DMA code") Fixes: e0a8b34 ("cxgb4vf: Add and initialize some sge params for VF driver") Fixes: c3168ca ("cxgb4/cxgbvf: Handle 32-bit fw port capabilities") Fixes: 0e23dae ("drivers/net: chelsio/cxgb*: Convert timers to use timer_setup()") Fixes: 3f8cfd0 ("cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()") Signed-off-by: Rahul Lakkireddy <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 29bbf5d commit 20bb0c8

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,8 +260,7 @@ static int cxgb4vf_set_addr_hash(struct port_info *pi)
260260
* @tcam_idx: TCAM index of existing filter for old value of MAC address,
261261
* or -1
262262
* @addr: the new MAC address value
263-
* @persist: whether a new MAC allocation should be persistent
264-
* @add_smt: if true also add the address to the HW SMT
263+
* @persistent: whether a new MAC allocation should be persistent
265264
*
266265
* Modifies an MPS filter and sets it to the new MAC address if
267266
* @tcam_idx >= 0, or adds the MAC address to a new filter if

drivers/net/ethernet/chelsio/cxgb4vf/sge.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1692,7 +1692,7 @@ static inline bool is_new_response(const struct rsp_ctrl *rc,
16921692
* restore_rx_bufs - put back a packet's RX buffers
16931693
* @gl: the packet gather list
16941694
* @fl: the SGE Free List
1695-
* @nfrags: how many fragments in @si
1695+
* @frags: how many fragments in @si
16961696
*
16971697
* Called when we find out that the current packet, @si, can't be
16981698
* processed right away for some reason. This is a very rare event and
@@ -2054,7 +2054,7 @@ irq_handler_t t4vf_intr_handler(struct adapter *adapter)
20542054

20552055
/**
20562056
* sge_rx_timer_cb - perform periodic maintenance of SGE RX queues
2057-
* @data: the adapter
2057+
* @t: Rx timer
20582058
*
20592059
* Runs periodically from a timer to perform maintenance of SGE RX queues.
20602060
*
@@ -2113,7 +2113,7 @@ static void sge_rx_timer_cb(struct timer_list *t)
21132113

21142114
/**
21152115
* sge_tx_timer_cb - perform periodic maintenance of SGE Tx queues
2116-
* @data: the adapter
2116+
* @t: Tx timer
21172117
*
21182118
* Runs periodically from a timer to perform maintenance of SGE TX queues.
21192119
*
@@ -2405,6 +2405,7 @@ int t4vf_sge_alloc_rxq(struct adapter *adapter, struct sge_rspq *rspq,
24052405
* t4vf_sge_alloc_eth_txq - allocate an SGE Ethernet TX Queue
24062406
* @adapter: the adapter
24072407
* @txq: pointer to the new txq to be filled in
2408+
* @dev: the network device
24082409
* @devq: the network TX queue associated with the new txq
24092410
* @iqid: the relative ingress queue ID to which events relating to
24102411
* the new txq should be directed

drivers/net/ethernet/chelsio/cxgb4vf/t4vf_hw.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -389,9 +389,7 @@ static inline enum cc_fec fwcap_to_cc_fec(fw_port_cap32_t fw_fec)
389389
return cc_fec;
390390
}
391391

392-
/**
393-
* Return the highest speed set in the port capabilities, in Mb/s.
394-
*/
392+
/* Return the highest speed set in the port capabilities, in Mb/s. */
395393
static unsigned int fwcap_to_speed(fw_port_cap32_t caps)
396394
{
397395
#define TEST_SPEED_RETURN(__caps_speed, __speed) \
@@ -1467,6 +1465,7 @@ int t4vf_identify_port(struct adapter *adapter, unsigned int viid,
14671465
* @bcast: 1 to enable broadcast Rx, 0 to disable it, -1 no change
14681466
* @vlanex: 1 to enable hardware VLAN Tag extraction, 0 to disable it,
14691467
* -1 no change
1468+
* @sleep_ok: call is allowed to sleep
14701469
*
14711470
* Sets Rx properties of a virtual interface.
14721471
*/
@@ -1906,7 +1905,7 @@ static const char *t4vf_link_down_rc_str(unsigned char link_down_rc)
19061905
/**
19071906
* t4vf_handle_get_port_info - process a FW reply message
19081907
* @pi: the port info
1909-
* @rpl: start of the FW message
1908+
* @cmd: start of the FW message
19101909
*
19111910
* Processes a GET_PORT_INFO FW reply message.
19121911
*/
@@ -2137,8 +2136,6 @@ int t4vf_handle_fw_rpl(struct adapter *adapter, const __be64 *rpl)
21372136
return 0;
21382137
}
21392138

2140-
/**
2141-
*/
21422139
int t4vf_prep_adapter(struct adapter *adapter)
21432140
{
21442141
int err;

0 commit comments

Comments
 (0)