Skip to content

Commit 21226f0

Browse files
Tao Zhoualexdeucher
authored andcommitted
drm/amdgpu: replace reset_error_count with amdgpu_ras_reset_error_count
Simplify the code. Signed-off-by: Tao Zhou <[email protected]> Reviewed-by: Hawking Zhang <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 9d7a965 commit 21226f0

File tree

5 files changed

+10
-25
lines changed

5 files changed

+10
-25
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3578,9 +3578,7 @@ static void amdgpu_device_xgmi_reset_func(struct work_struct *__work)
35783578
if (adev->asic_reset_res)
35793579
goto fail;
35803580

3581-
if (adev->mmhub.ras && adev->mmhub.ras->ras_block.hw_ops &&
3582-
adev->mmhub.ras->ras_block.hw_ops->reset_ras_error_count)
3583-
adev->mmhub.ras->ras_block.hw_ops->reset_ras_error_count(adev);
3581+
amdgpu_ras_reset_error_count(adev, AMDGPU_RAS_BLOCK__MMHUB);
35843582
} else {
35853583

35863584
task_barrier_full(&hive->tb);
@@ -5201,9 +5199,7 @@ int amdgpu_do_asic_reset(struct list_head *device_list_handle,
52015199

52025200
if (!r && amdgpu_ras_intr_triggered()) {
52035201
list_for_each_entry(tmp_adev, device_list_handle, reset_list) {
5204-
if (tmp_adev->mmhub.ras && tmp_adev->mmhub.ras->ras_block.hw_ops &&
5205-
tmp_adev->mmhub.ras->ras_block.hw_ops->reset_ras_error_count)
5206-
tmp_adev->mmhub.ras->ras_block.hw_ops->reset_ras_error_count(tmp_adev);
5202+
amdgpu_ras_reset_error_count(tmp_adev, AMDGPU_RAS_BLOCK__MMHUB);
52075203
}
52085204

52095205
amdgpu_ras_intr_cleared();

drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ static int amdgpu_xgmi_ras_late_init(struct amdgpu_device *adev, struct ras_comm
908908
adev->gmc.xgmi.num_physical_nodes == 0)
909909
return 0;
910910

911-
adev->gmc.xgmi.ras->ras_block.hw_ops->reset_ras_error_count(adev);
911+
amdgpu_ras_reset_error_count(adev, AMDGPU_RAS_BLOCK__XGMI_WAFL);
912912

913913
return amdgpu_ras_block_late_init(adev, ras_block);
914914
}
@@ -1075,7 +1075,7 @@ static void amdgpu_xgmi_query_ras_error_count(struct amdgpu_device *adev,
10751075
break;
10761076
}
10771077

1078-
adev->gmc.xgmi.ras->ras_block.hw_ops->reset_ras_error_count(adev);
1078+
amdgpu_ras_reset_error_count(adev, AMDGPU_RAS_BLOCK__XGMI_WAFL);
10791079

10801080
err_data->ue_count += ue_cnt;
10811081
err_data->ce_count += ce_cnt;

drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1587,13 +1587,8 @@ static int gmc_v9_0_late_init(void *handle)
15871587
}
15881588

15891589
if (!amdgpu_persistent_edc_harvesting_supported(adev)) {
1590-
if (adev->mmhub.ras && adev->mmhub.ras->ras_block.hw_ops &&
1591-
adev->mmhub.ras->ras_block.hw_ops->reset_ras_error_count)
1592-
adev->mmhub.ras->ras_block.hw_ops->reset_ras_error_count(adev);
1593-
1594-
if (adev->hdp.ras && adev->hdp.ras->ras_block.hw_ops &&
1595-
adev->hdp.ras->ras_block.hw_ops->reset_ras_error_count)
1596-
adev->hdp.ras->ras_block.hw_ops->reset_ras_error_count(adev);
1590+
amdgpu_ras_reset_error_count(adev, AMDGPU_RAS_BLOCK__MMHUB);
1591+
amdgpu_ras_reset_error_count(adev, AMDGPU_RAS_BLOCK__HDP);
15971592
}
15981593

15991594
r = amdgpu_gmc_ras_late_init(adev);

drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1749,11 +1749,8 @@ static int sdma_v4_0_late_init(void *handle)
17491749

17501750
sdma_v4_0_setup_ulv(adev);
17511751

1752-
if (!amdgpu_persistent_edc_harvesting_supported(adev)) {
1753-
if (adev->sdma.ras && adev->sdma.ras->ras_block.hw_ops &&
1754-
adev->sdma.ras->ras_block.hw_ops->reset_ras_error_count)
1755-
adev->sdma.ras->ras_block.hw_ops->reset_ras_error_count(adev);
1756-
}
1752+
if (!amdgpu_persistent_edc_harvesting_supported(adev))
1753+
amdgpu_ras_reset_error_count(adev, AMDGPU_RAS_BLOCK__SDMA);
17571754

17581755
return 0;
17591756
}

drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1276,11 +1276,8 @@ static int sdma_v4_4_2_late_init(void *handle)
12761276
.cb = sdma_v4_4_2_process_ras_data_cb,
12771277
};
12781278
#endif
1279-
if (!amdgpu_persistent_edc_harvesting_supported(adev)) {
1280-
if (adev->sdma.ras && adev->sdma.ras->ras_block.hw_ops &&
1281-
adev->sdma.ras->ras_block.hw_ops->reset_ras_error_count)
1282-
adev->sdma.ras->ras_block.hw_ops->reset_ras_error_count(adev);
1283-
}
1279+
if (!amdgpu_persistent_edc_harvesting_supported(adev))
1280+
amdgpu_ras_reset_error_count(adev, AMDGPU_RAS_BLOCK__SDMA);
12841281

12851282
return 0;
12861283
}

0 commit comments

Comments
 (0)