Skip to content

Commit 213fca9

Browse files
svens-s390Vasily Gorbik
authored andcommitted
s390/tape: fix timer initialization in tape_std_assign()
commit 9c6c273 ("timer: Remove init_timer_on_stack() in favor of timer_setup_on_stack()") changed the timer setup from init_timer_on_stack(() to timer_setup(), but missed to change the mod_timer() call. And while at it, use msecs_to_jiffies() instead of the open coded timeout calculation. Cc: [email protected] Fixes: 9c6c273 ("timer: Remove init_timer_on_stack() in favor of timer_setup_on_stack()") Signed-off-by: Sven Schnelle <[email protected]> Reviewed-by: Vasily Gorbik <[email protected]> Signed-off-by: Vasily Gorbik <[email protected]>
1 parent 4cdf2f4 commit 213fca9

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/s390/char/tape_std.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ int
5353
tape_std_assign(struct tape_device *device)
5454
{
5555
int rc;
56-
struct timer_list timeout;
5756
struct tape_request *request;
5857

5958
request = tape_alloc_request(2, 11);
@@ -70,7 +69,7 @@ tape_std_assign(struct tape_device *device)
7069
* So we set up a timeout for this call.
7170
*/
7271
timer_setup(&request->timer, tape_std_assign_timeout, 0);
73-
mod_timer(&timeout, jiffies + 2 * HZ);
72+
mod_timer(&request->timer, jiffies + msecs_to_jiffies(2000));
7473

7574
rc = tape_do_io_interruptible(device, request);
7675

0 commit comments

Comments
 (0)