Skip to content

Commit 215113a

Browse files
keveryangMani-Sadhasivam
authored andcommitted
dt-bindings: PCI: dw: rockchip: Add rk3576 support
rk3576 is using DWC PCIe controller, with msi interrupt directly to GIC instead of using GIC ITS, so - no ITS support is required and the 'msi-map' is not required, - a new 'msi' interrupt is needed. Co-developed-by: Sebastian Reichel <[email protected]> Signed-off-by: Sebastian Reichel <[email protected]> Signed-off-by: Kever Yang <[email protected]> [mani: changed 'its' to 'ITS' in the binding, spelling mistake fix] Signed-off-by: Manivannan Sadhasivam <[email protected]> Reviewed-by: Rob Herring (Arm) <[email protected]> Reviewed-by: Heiko Stuebner <[email protected]> Link: https://patch.msgid.link/[email protected]
1 parent cc9f71d commit 215113a

File tree

2 files changed

+57
-8
lines changed

2 files changed

+57
-8
lines changed

Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,11 @@ properties:
6565
tx_cpl_timeout, cor_err_sent, nf_err_sent, f_err_sent, cor_err_rx,
6666
nf_err_rx, f_err_rx, radm_qoverflow
6767
- description:
68-
eDMA write channel 0 interrupt
68+
If the matching interrupt name is "msi", then this is the combined
69+
MSI line interrupt, which is to support MSI interrupts output to GIC
70+
controller via GIC SPI interrupt instead of GIC ITS interrupt.
71+
If the matching interrupt name is "dma0", then this is the eDMA write
72+
channel 0 interrupt.
6973
- description:
7074
eDMA write channel 1 interrupt
7175
- description:
@@ -81,7 +85,9 @@ properties:
8185
- const: msg
8286
- const: legacy
8387
- const: err
84-
- const: dma0
88+
- enum:
89+
- msi
90+
- dma0
8591
- const: dma1
8692
- const: dma2
8793
- const: dma3

Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml

Lines changed: 49 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,13 @@ description: |+
1616
PCIe IP and thus inherits all the common properties defined in
1717
snps,dw-pcie.yaml.
1818
19-
allOf:
20-
- $ref: /schemas/pci/snps,dw-pcie.yaml#
21-
- $ref: /schemas/pci/rockchip-dw-pcie-common.yaml#
22-
2319
properties:
2420
compatible:
2521
oneOf:
2622
- const: rockchip,rk3568-pcie
2723
- items:
2824
- enum:
25+
- rockchip,rk3576-pcie
2926
- rockchip,rk3588-pcie
3027
- const: rockchip,rk3568-pcie
3128

@@ -71,8 +68,54 @@ properties:
7168

7269
vpcie3v3-supply: true
7370

74-
required:
75-
- msi-map
71+
allOf:
72+
- $ref: /schemas/pci/snps,dw-pcie.yaml#
73+
- $ref: /schemas/pci/rockchip-dw-pcie-common.yaml#
74+
- if:
75+
not:
76+
properties:
77+
compatible:
78+
contains:
79+
const: rockchip,rk3576-pcie
80+
then:
81+
required:
82+
- msi-map
83+
84+
- if:
85+
properties:
86+
compatible:
87+
contains:
88+
const: rockchip,rk3576-pcie
89+
then:
90+
properties:
91+
interrupts:
92+
minItems: 6
93+
maxItems: 6
94+
interrupt-names:
95+
items:
96+
- const: sys
97+
- const: pmc
98+
- const: msg
99+
- const: legacy
100+
- const: err
101+
- const: msi
102+
else:
103+
properties:
104+
interrupts:
105+
minItems: 5
106+
interrupt-names:
107+
minItems: 5
108+
items:
109+
- const: sys
110+
- const: pmc
111+
- const: msg
112+
- const: legacy
113+
- const: err
114+
- const: dma0
115+
- const: dma1
116+
- const: dma2
117+
- const: dma3
118+
76119

77120
unevaluatedProperties: false
78121

0 commit comments

Comments
 (0)