Skip to content

Commit 2158566

Browse files
Andi Shytiwsakernel
authored andcommitted
i2c: mt7621: Use devm_clk_get_enabled()
Replace the pair of functions, devm_clk_get() and clk_prepare_enable(), with a single function devm_clk_get_enabled(). Signed-off-by: Andi Shyti <[email protected]> Reviewed-by: Matthias Brugger <[email protected]> Reviewed-by: Stefan Roese <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 8390dc7 commit 2158566

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

drivers/i2c/busses/i2c-mt7621.c

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -282,16 +282,11 @@ static int mtk_i2c_probe(struct platform_device *pdev)
282282
if (IS_ERR(i2c->base))
283283
return PTR_ERR(i2c->base);
284284

285-
i2c->clk = devm_clk_get(&pdev->dev, NULL);
285+
i2c->clk = devm_clk_get_enabled(&pdev->dev, NULL);
286286
if (IS_ERR(i2c->clk)) {
287-
dev_err(&pdev->dev, "no clock defined\n");
287+
dev_err(&pdev->dev, "Failed to enable clock\n");
288288
return PTR_ERR(i2c->clk);
289289
}
290-
ret = clk_prepare_enable(i2c->clk);
291-
if (ret) {
292-
dev_err(&pdev->dev, "Unable to enable clock\n");
293-
return ret;
294-
}
295290

296291
i2c->dev = &pdev->dev;
297292

@@ -301,8 +296,7 @@ static int mtk_i2c_probe(struct platform_device *pdev)
301296

302297
if (i2c->bus_freq == 0) {
303298
dev_warn(i2c->dev, "clock-frequency 0 not supported\n");
304-
ret = -EINVAL;
305-
goto err_disable_clk;
299+
return -EINVAL;
306300
}
307301

308302
adap = &i2c->adap;
@@ -320,23 +314,17 @@ static int mtk_i2c_probe(struct platform_device *pdev)
320314

321315
ret = i2c_add_adapter(adap);
322316
if (ret < 0)
323-
goto err_disable_clk;
317+
return ret;
324318

325319
dev_info(&pdev->dev, "clock %u kHz\n", i2c->bus_freq / 1000);
326320

327321
return 0;
328-
329-
err_disable_clk:
330-
clk_disable_unprepare(i2c->clk);
331-
332-
return ret;
333322
}
334323

335324
static void mtk_i2c_remove(struct platform_device *pdev)
336325
{
337326
struct mtk_i2c *i2c = platform_get_drvdata(pdev);
338327

339-
clk_disable_unprepare(i2c->clk);
340328
i2c_del_adapter(&i2c->adap);
341329
}
342330

0 commit comments

Comments
 (0)