Skip to content

Commit 2182e0f

Browse files
arndbThomas Zimmermann
authored andcommitted
drm: rework FB_CORE dependency
The 'select FB_CORE' statement moved from CONFIG_DRM to DRM_CLIENT_LIB, but there are now configurations that have code calling into fb_core as built-in even though the client_lib itself is a loadable module: x86_64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_set_suspend': drm_fb_helper.c:(.text+0x2c6): undefined reference to `fb_set_suspend' x86_64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_resume_worker': drm_fb_helper.c:(.text+0x2e1): undefined reference to `fb_set_suspend' In addition to DRM_CLIENT_LIB, the 'select' needs to be at least in DRM_KMS_HELPER and DRM_GEM_SHMEM_HELPER, so add it here. This patch is the KMS_HELPER part of [1]. Fixes: dadd28d ("drm/client: Add client-lib module") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Thomas Zimmermann <[email protected]> Link: https://patchwork.freedesktop.org/series/141411/ # 1 Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Thomas Zimmermann <[email protected]>
1 parent 8ce35bf commit 2182e0f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ config DRM_KUNIT_TEST
9999
config DRM_KMS_HELPER
100100
tristate
101101
depends on DRM
102+
select FB_CORE if DRM_FBDEV_EMULATION
102103
help
103104
CRTC helpers for KMS drivers.
104105

0 commit comments

Comments
 (0)