ethtool: Fix check in ethtool_rx_flow_rule_create

gaurav1086 · davem330 · commit 21a739c64d3e · 2020-06-22T20:48:12.000-07:00
Fix check in ethtool_rx_flow_rule_create Fixes: eca4205 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator") Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
@@ -2978,7 +2978,7 @@ ethtool_rx_flow_rule_create(const struct ethtool_rx_flow_spec_input *input)
 			       sizeof(match->mask.ipv6.dst));
 		}
 		if (memcmp(v6_m_spec->ip6src, &zero_addr, sizeof(zero_addr)) ||
-		    memcmp(v6_m_spec->ip6src, &zero_addr, sizeof(zero_addr))) {
+		    memcmp(v6_m_spec->ip6dst, &zero_addr, sizeof(zero_addr))) {
 			match->dissector.used_keys |=
 				BIT(FLOW_DISSECTOR_KEY_IPV6_ADDRS);
 			match->dissector.offset[FLOW_DISSECTOR_KEY_IPV6_ADDRS] =

Original file line number	Diff line number	Diff line change
`@@ -2978,7 +2978,7 @@ ethtool_rx_flow_rule_create(const struct ethtool_rx_flow_spec_input *input)`
`2978`	`2978`	`sizeof(match->mask.ipv6.dst));`
`2979`	`2979`	`}`
`2980`	`2980`	`if (memcmp(v6_m_spec->ip6src, &zero_addr, sizeof(zero_addr)) \|\|`
`2981`		`- memcmp(v6_m_spec->ip6src, &zero_addr, sizeof(zero_addr))) {`
	`2981`	`+ memcmp(v6_m_spec->ip6dst, &zero_addr, sizeof(zero_addr))) {`
`2982`	`2982`	`match->dissector.used_keys \|=`
`2983`	`2983`	`BIT(FLOW_DISSECTOR_KEY_IPV6_ADDRS);`
`2984`	`2984`	`match->dissector.offset[FLOW_DISSECTOR_KEY_IPV6_ADDRS] =`