Skip to content

Commit 21acee4

Browse files
Dan CarpenterJiri Kosina
authored andcommitted
HID: intel-ish-hid: Fix a use after free in load_fw_from_host()
We have to print the filename first before we can kfree it. Fixes: 91b2281 ("HID: intel-ish-hid: ISH firmware loader client driver") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 3ed224e commit 21acee4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hid/intel-ish-hid/ishtp-fw-loader.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -816,9 +816,9 @@ static int load_fw_from_host(struct ishtp_cl_data *client_data)
816816
goto end_err_fw_release;
817817

818818
release_firmware(fw);
819-
kfree(filename);
820819
dev_info(cl_data_to_dev(client_data), "ISH firmware %s loaded\n",
821820
filename);
821+
kfree(filename);
822822
return 0;
823823

824824
end_err_fw_release:

0 commit comments

Comments
 (0)