Skip to content

Commit 21e330f

Browse files
shakeelbtorvalds
authored andcommitted
mm: swap: memcg: fix memcg stats for huge pages
The commit 2262185 ("mm: per-cgroup memory reclaim stats") added PGLAZYFREE, PGACTIVATE & PGDEACTIVATE stats for cgroups but missed couple of places and PGLAZYFREE missed huge page handling. Fix that. Also for PGLAZYFREE use the irq-unsafe function to update as the irq is already disabled. Fixes: 2262185 ("mm: per-cgroup memory reclaim stats") Signed-off-by: Shakeel Butt <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Acked-by: Johannes Weiner <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Linus Torvalds <[email protected]>
1 parent 5d91f31 commit 21e330f

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

mm/swap.c

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -320,14 +320,17 @@ static void __activate_page(struct page *page, struct lruvec *lruvec,
320320
{
321321
if (PageLRU(page) && !PageActive(page) && !PageUnevictable(page)) {
322322
int lru = page_lru_base_type(page);
323+
int nr_pages = hpage_nr_pages(page);
323324

324325
del_page_from_lru_list(page, lruvec, lru);
325326
SetPageActive(page);
326327
lru += LRU_ACTIVE;
327328
add_page_to_lru_list(page, lruvec, lru);
328329
trace_mm_lru_activate(page);
329330

330-
__count_vm_events(PGACTIVATE, hpage_nr_pages(page));
331+
__count_vm_events(PGACTIVATE, nr_pages);
332+
__count_memcg_events(lruvec_memcg(lruvec), PGACTIVATE,
333+
nr_pages);
331334
}
332335
}
333336

@@ -565,22 +568,28 @@ static void lru_deactivate_file_fn(struct page *page, struct lruvec *lruvec,
565568
__count_vm_events(PGROTATED, nr_pages);
566569
}
567570

568-
if (active)
571+
if (active) {
569572
__count_vm_events(PGDEACTIVATE, nr_pages);
573+
__count_memcg_events(lruvec_memcg(lruvec), PGDEACTIVATE,
574+
nr_pages);
575+
}
570576
}
571577

572578
static void lru_deactivate_fn(struct page *page, struct lruvec *lruvec,
573579
void *arg)
574580
{
575581
if (PageLRU(page) && PageActive(page) && !PageUnevictable(page)) {
576582
int lru = page_lru_base_type(page);
583+
int nr_pages = hpage_nr_pages(page);
577584

578585
del_page_from_lru_list(page, lruvec, lru + LRU_ACTIVE);
579586
ClearPageActive(page);
580587
ClearPageReferenced(page);
581588
add_page_to_lru_list(page, lruvec, lru);
582589

583-
__count_vm_events(PGDEACTIVATE, hpage_nr_pages(page));
590+
__count_vm_events(PGDEACTIVATE, nr_pages);
591+
__count_memcg_events(lruvec_memcg(lruvec), PGDEACTIVATE,
592+
nr_pages);
584593
}
585594
}
586595

@@ -590,6 +599,7 @@ static void lru_lazyfree_fn(struct page *page, struct lruvec *lruvec,
590599
if (PageLRU(page) && PageAnon(page) && PageSwapBacked(page) &&
591600
!PageSwapCache(page) && !PageUnevictable(page)) {
592601
bool active = PageActive(page);
602+
int nr_pages = hpage_nr_pages(page);
593603

594604
del_page_from_lru_list(page, lruvec,
595605
LRU_INACTIVE_ANON + active);
@@ -603,8 +613,9 @@ static void lru_lazyfree_fn(struct page *page, struct lruvec *lruvec,
603613
ClearPageSwapBacked(page);
604614
add_page_to_lru_list(page, lruvec, LRU_INACTIVE_FILE);
605615

606-
__count_vm_events(PGLAZYFREE, hpage_nr_pages(page));
607-
count_memcg_page_event(page, PGLAZYFREE);
616+
__count_vm_events(PGLAZYFREE, nr_pages);
617+
__count_memcg_events(lruvec_memcg(lruvec), PGLAZYFREE,
618+
nr_pages);
608619
}
609620
}
610621

0 commit comments

Comments
 (0)