Skip to content

Commit 21ff365

Browse files
vdonnefortrostedt
authored andcommitted
selftests/ring-buffer: Verify the entire meta-page padding
Improve the ring-buffer meta-page test coverage by checking for the entire padding region to be 0 instead of just looking at the first 4 bytes. Cc: [email protected] Link: https://lore.kernel.org/[email protected] Acked-by: Shuah Khan <[email protected]> Signed-off-by: Vincent Donnefort <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent 2fcd5af commit 21ff365

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tools/testing/selftests/ring-buffer/map_test.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,15 +231,15 @@ TEST_F(map, data_mmap)
231231

232232
/* Verify meta-page padding */
233233
if (desc->meta->meta_page_size > getpagesize()) {
234-
void *addr;
235-
236234
data_len = desc->meta->meta_page_size;
237235
data = mmap(NULL, data_len,
238236
PROT_READ, MAP_SHARED, desc->cpu_fd, 0);
239237
ASSERT_NE(data, MAP_FAILED);
240238

241-
addr = (void *)((unsigned long)data + getpagesize());
242-
ASSERT_EQ(*((int *)addr), 0);
239+
for (int i = desc->meta->meta_struct_len;
240+
i < desc->meta->meta_page_size; i += sizeof(int))
241+
ASSERT_EQ(*(int *)(data + i), 0);
242+
243243
munmap(data, data_len);
244244
}
245245
}

0 commit comments

Comments
 (0)