Skip to content

Commit 222a87f

Browse files
krzkbroonie
authored andcommitted
spi: cadence-quadspi: Assume device could match via platform
Driver has only of_device_id table, however it also has MODULE_ALIAS() for platform name, thus assume there is a configuration where this can be loaded outside of OF system. In such case of_device_get_match_data() will return NULL, which is already checked in one place of probe() function but not in the other, leading to Smatch warning: drivers/spi/spi-cadence-quadspi.c:1942 cqspi_probe() error: we previously assumed 'ddata' could be null (see line 1885) Driver should be consistent, so assume device can be matched via platform bus and of_device_get_match_data() can indeed return NULL. This is also possible with malformed DTS on OF-platform: no unit address and device node name matching driver name. Signed-off-by: Krzysztof Kozlowski <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent f4ea37a commit 222a87f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/spi/spi-cadence-quadspi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1949,7 +1949,7 @@ static int cqspi_probe(struct platform_device *pdev)
19491949

19501950
host->num_chipselect = cqspi->num_chipselect;
19511951

1952-
if (ddata->quirks & CQSPI_SUPPORT_DEVICE_RESET)
1952+
if (ddata && (ddata->quirks & CQSPI_SUPPORT_DEVICE_RESET))
19531953
cqspi_device_reset(cqspi);
19541954

19551955
if (cqspi->use_direct_mode) {

0 commit comments

Comments
 (0)