Skip to content

Commit 225a2ec

Browse files
committed
pinctrl: samsung: Fix missing OF and GPIOLIB dependency on S3C24xx and S3C64xx
All Samsung pinctrl drivers select common part - PINCTRL_SAMSUNG which uses both OF and GPIOLIB inside. However only Exynos drivers depend on these, therefore after enabling COMPILE_TEST, on x86_64 build of S3C64xx driver failed: drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpiolib_register’: drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: ‘struct gpio_chip’ has no member named ‘of_node’ gc->of_node = bank->of_node; ^ Rework the dependencies so all Samsung drivers and common PINCTRL_SAMSUNG part depend on OF_GPIO (which is default yes if GPIOLIB and OF are enabled). Reported-by: Chen Zhou <[email protected]> Signed-off-by: Krzysztof Kozlowski <[email protected]>
1 parent 56d9625 commit 225a2ec

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/pinctrl/samsung/Kconfig

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@
44
#
55
config PINCTRL_SAMSUNG
66
bool
7+
depends on OF_GPIO
78
select PINMUX
89
select PINCONF
910

1011
config PINCTRL_EXYNOS
1112
bool "Pinctrl common driver part for Samsung Exynos SoCs"
12-
depends on OF && GPIOLIB
13+
depends on OF_GPIO
1314
depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST
1415
select PINCTRL_SAMSUNG
1516
select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210)
@@ -25,11 +26,12 @@ config PINCTRL_EXYNOS_ARM64
2526

2627
config PINCTRL_S3C24XX
2728
bool "Samsung S3C24XX SoC pinctrl driver"
28-
depends on OF
29+
depends on OF_GPIO
2930
depends on ARCH_S3C24XX || COMPILE_TEST
3031
select PINCTRL_SAMSUNG
3132

3233
config PINCTRL_S3C64XX
3334
bool "Samsung S3C64XX SoC pinctrl driver"
35+
depends on OF_GPIO
3436
depends on ARCH_S3C64XX || COMPILE_TEST
3537
select PINCTRL_SAMSUNG

0 commit comments

Comments
 (0)